Attention is currently required from: Eran Mitrani, Jakub Czapiga, Jeremy Soller, Jonathon Hall, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Subrata Banik, Tarun, Tim Crawford, Werner Zeh.
Hello Eran Mitrani, Jakub Czapiga, Jeremy Soller, Jonathon Hall, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Subrata Banik, Tarun, Tim Crawford, Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/77582?usp=email
to look at the new patch set (#3).
Change subject: soc/intel/gpio: Change the GPIO device scope in ACPI to _SB ......................................................................
soc/intel/gpio: Change the GPIO device scope in ACPI to _SB
Windows expects the GPIO device to be under _SB, not _SB.PCI0, otherwise it raises a yellow bang in the Device Manager with an error indicating that the device could not find enough free resources (despite avoiding the proper SBREG BAR reservation in MCHC resources).
TEST=Boot Windows 11 on MSI PRO Z790-P and notice the yellow bang near GPIO device in Device Manager is gone.
Change-Id: I1e6259817eeb7bca833ed54834660544c819dc25 Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com --- M src/mainboard/purism/librem_cnl/variants/librem_mini/include/variant/acpi/variant.asl M src/soc/intel/alderlake/acpi/gpio.asl M src/soc/intel/alderlake/gpio.c M src/soc/intel/alderlake/gpio_pch_s.c M src/soc/intel/cannonlake/acpi/gpio.asl M src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl M src/soc/intel/cannonlake/gpio.c M src/soc/intel/cannonlake/gpio_cnp_h.c M src/soc/intel/common/block/acpi/acpi/northbridge.asl M src/soc/intel/elkhartlake/acpi/gpio.asl M src/soc/intel/elkhartlake/gpio.c M src/soc/intel/jasperlake/acpi/gpio.asl M src/soc/intel/jasperlake/gpio.c M src/soc/intel/meteorlake/acpi/gpio.asl M src/soc/intel/meteorlake/gpio.c M src/soc/intel/tigerlake/acpi/gpio.asl M src/soc/intel/tigerlake/acpi/gpio_pch_h.asl M src/soc/intel/tigerlake/gpio.c M src/soc/intel/tigerlake/gpio_pch_h.c 19 files changed, 734 insertions(+), 710 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/77582/3