Attention is currently required from: Michał Żygowski, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59524 )
Change subject: superio/smsc/sch5545: Fix KBD and Runtime Registers init
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59524/comment/bb202aa3_836dac2f
PS3, Line 17: be always
nit: `always be`
File src/superio/smsc/sch5545/superio.c:
https://review.coreboot.org/c/coreboot/+/59524/comment/d7333bf1_ac86eab0
PS3, Line 68: pnp_write_config(dev, 0xf0, pnp_read_config(dev, 0xf0) & 0x9f);
How about:
pnp_unset_and_set_config(dev, 0xf0, 3 << 5, 0);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59524
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I790cac3ce1101565b64ed54d9c6b50f5e9aa4cf6
Gerrit-Change-Number: 59524
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 25 Nov 2021 11:08:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment