John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32516
Change subject: ACPI: Update VT-d DMA remapping structure flags setting ......................................................................
ACPI: Update VT-d DMA remapping structure flags setting
DMA remapping structure flags settings are Bit 0: INTR_REMAP, Bit 1: X2APIC_OPT_OUT, Bit 2: DMA_CTRL_PLATFORM_OPT_IN_FLAG, Bits 3-7: Reserved (0).
BUG=b:130351429 TEST=Image built and kernel booted to kernel.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Iaf4764a9062756cadc335d1932b0da8628797f5f --- M src/arch/x86/include/arch/acpi.h 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/32516/1
diff --git a/src/arch/x86/include/arch/acpi.h b/src/arch/x86/include/arch/acpi.h index 1b9438d..79feaad 100644 --- a/src/arch/x86/include/arch/acpi.h +++ b/src/arch/x86/include/arch/acpi.h @@ -335,9 +335,9 @@ };
enum dmar_flags { - DMAR_INTR_REMAP = 1, - DMAR_X2APIC_OPT_OUT = 2, - DMA_CTRL_PLATFORM_OPT_IN_FLAG = 3, + DMAR_INTR_REMAP = 1 << 0, + DMAR_X2APIC_OPT_OUT = 1 << 1, + DMA_CTRL_PLATFORM_OPT_IN_FLAG = 1 << 2, };
typedef struct dmar_entry {
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32516 )
Change subject: ACPI: Update VT-d DMA remapping structure flags setting ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32516/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32516/1//COMMIT_MSG@7 PS1, Line 7: ACPI nit: arch/x86/acpi?
Hello build bot (Jenkins), Lijian Zhao, Nico Huber, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32516
to look at the new patch set (#2).
Change subject: arch/x86/acpi: Update VT-d DMA remapping structure flags setting ......................................................................
arch/x86/acpi: Update VT-d DMA remapping structure flags setting
DMA remapping structure flags settings are Bit 0: INTR_REMAP, Bit 1: X2APIC_OPT_OUT, Bit 2: DMA_CTRL_PLATFORM_OPT_IN_FLAG, Bits 3-7: Reserved (0).
BUG=b:130351429 TEST=Image built and kernel booted to kernel.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Iaf4764a9062756cadc335d1932b0da8628797f5f --- M src/arch/x86/include/arch/acpi.h 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/32516/2
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32516 )
Change subject: arch/x86/acpi: Update VT-d DMA remapping structure flags setting ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32516/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32516/1//COMMIT_MSG@7 PS1, Line 7: ACPI
nit: arch/x86/acpi?
Updated.
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32516 )
Change subject: arch/x86/acpi: Update VT-d DMA remapping structure flags setting ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32516 )
Change subject: arch/x86/acpi: Update VT-d DMA remapping structure flags setting ......................................................................
arch/x86/acpi: Update VT-d DMA remapping structure flags setting
DMA remapping structure flags settings are Bit 0: INTR_REMAP, Bit 1: X2APIC_OPT_OUT, Bit 2: DMA_CTRL_PLATFORM_OPT_IN_FLAG, Bits 3-7: Reserved (0).
BUG=b:130351429 TEST=Image built and kernel booted to kernel.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Iaf4764a9062756cadc335d1932b0da8628797f5f Reviewed-on: https://review.coreboot.org/c/coreboot/+/32516 Reviewed-by: Lijian Zhao lijian.zhao@intel.com Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/x86/include/arch/acpi.h 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Lijian Zhao: Looks good to me, approved
diff --git a/src/arch/x86/include/arch/acpi.h b/src/arch/x86/include/arch/acpi.h index 1b9438d..79feaad 100644 --- a/src/arch/x86/include/arch/acpi.h +++ b/src/arch/x86/include/arch/acpi.h @@ -335,9 +335,9 @@ };
enum dmar_flags { - DMAR_INTR_REMAP = 1, - DMAR_X2APIC_OPT_OUT = 2, - DMA_CTRL_PLATFORM_OPT_IN_FLAG = 3, + DMAR_INTR_REMAP = 1 << 0, + DMAR_X2APIC_OPT_OUT = 1 << 1, + DMA_CTRL_PLATFORM_OPT_IN_FLAG = 1 << 2, };
typedef struct dmar_entry {
-
Furquan Shaikh (Code Review) -
John Zhao (Code Review)
-
Lijian Zhao (Code Review)
-
Nico Huber (Code Review)