Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32525
Change subject: google/cyan,intel/strago: increase default CBFS size ......................................................................
google/cyan,intel/strago: increase default CBFS size
a 1M CBFS size is inadequate when adding the FSP binary to image due to default FSP location in CBFS, so bump to 2M to ensure autobuilds succeed.
Change-Id: I0683bea43cc71fad32bc42bfbd72f3913256d53c Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/cyan/Kconfig M src/mainboard/intel/strago/Kconfig 2 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/32525/1
diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig index 1d9b7b7..b3c6790 100644 --- a/src/mainboard/google/cyan/Kconfig +++ b/src/mainboard/google/cyan/Kconfig @@ -107,4 +107,8 @@ default "ULTIMA TEST A-A 6017" if BOARD_GOOGLE_ULTIMA default "WIZPIG TEST A-A 0597" if BOARD_GOOGLE_WIZPIG
+config CBFS_SIZE + hex + default 0x200000 + endif # BOARD_GOOGLE_BASEBOARD_CYAN diff --git a/src/mainboard/intel/strago/Kconfig b/src/mainboard/intel/strago/Kconfig index 4aa7640..da04d78 100644 --- a/src/mainboard/intel/strago/Kconfig +++ b/src/mainboard/intel/strago/Kconfig @@ -58,4 +58,9 @@ string depends on CHROMEOS default "STRAGO TEST A-A 9657" + +config CBFS_SIZE + hex + default 0x200000 + endif # BOARD_INTEL_STRAGO
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32525 )
Change subject: google/cyan,intel/strago: increase default CBFS size ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32525 )
Change subject: google/cyan,intel/strago: increase default CBFS size ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32525 )
Change subject: google/cyan,intel/strago: increase default CBFS size ......................................................................
google/cyan,intel/strago: increase default CBFS size
a 1M CBFS size is inadequate when adding the FSP binary to image due to default FSP location in CBFS, so bump to 2M to ensure autobuilds succeed.
Change-Id: I0683bea43cc71fad32bc42bfbd72f3913256d53c Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32525 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/google/cyan/Kconfig M src/mainboard/intel/strago/Kconfig 2 files changed, 9 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig index 1d9b7b7..b3c6790 100644 --- a/src/mainboard/google/cyan/Kconfig +++ b/src/mainboard/google/cyan/Kconfig @@ -107,4 +107,8 @@ default "ULTIMA TEST A-A 6017" if BOARD_GOOGLE_ULTIMA default "WIZPIG TEST A-A 0597" if BOARD_GOOGLE_WIZPIG
+config CBFS_SIZE + hex + default 0x200000 + endif # BOARD_GOOGLE_BASEBOARD_CYAN diff --git a/src/mainboard/intel/strago/Kconfig b/src/mainboard/intel/strago/Kconfig index 4aa7640..da04d78 100644 --- a/src/mainboard/intel/strago/Kconfig +++ b/src/mainboard/intel/strago/Kconfig @@ -58,4 +58,9 @@ string depends on CHROMEOS default "STRAGO TEST A-A 9657" + +config CBFS_SIZE + hex + default 0x200000 + endif # BOARD_INTEL_STRAGO
-
Martin Roth (Code Review) -
Matt DeVillier (Code Review)
-
Nico Huber (Code Review)