Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75366?usp=email )
(
3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/intel/apollolake: Make hard drive type for SATA ports configurable ......................................................................
soc/intel/apollolake: Make hard drive type for SATA ports configurable
Intel's APL FSP offers the possibility to select the connected hard drive type to SATA ports. One has the option to choose between HDD ('0' - default) and SSD ('1').
This patch provides a chip config so that this FSP parameter can be set as needed in the devicetree on mainboard level.
Change-Id: I52c3566fb3c959ada6be33f0546ac331f4867d10 Signed-off-by: Mario Scheithauer mario.scheithauer@siemens.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/75366 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jan Samek jan.samek@siemens.com --- M src/soc/intel/apollolake/chip.c M src/soc/intel/apollolake/chip.h 2 files changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Jan Samek: Looks good to me, approved
diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c index bd40595..7147011 100644 --- a/src/soc/intel/apollolake/chip.c +++ b/src/soc/intel/apollolake/chip.c @@ -739,6 +739,8 @@ silconfig->SpeedLimit = cfg->sata_speed; memcpy(silconfig->SataPortsEnable, cfg->SataPortsEnable, sizeof(silconfig->SataPortsEnable)); + memcpy(silconfig->SataPortsSolidStateDrive, cfg->sata_ports_ssd, + sizeof(silconfig->SataPortsSolidStateDrive)); }
/* Sata Power Optimisation */ diff --git a/src/soc/intel/apollolake/chip.h b/src/soc/intel/apollolake/chip.h index 3951880..45b60d3 100644 --- a/src/soc/intel/apollolake/chip.h +++ b/src/soc/intel/apollolake/chip.h @@ -109,6 +109,9 @@ /* Sata Ports Enable */ uint8_t SataPortsEnable[2];
+ /* Sata Ports Solid State Drive */ + uint8_t sata_ports_ssd[2]; + /* Specifies on which IRQ the SCI will internally appear. */ uint8_t sci_irq;