Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35317 )
Change subject: mediatek/mt8183: tune EDID for BOE panel ......................................................................
mediatek/mt8183: tune EDID for BOE panel
BUG=b:140545315 TEST=builds Kodama image and verify display working properly
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I52a56f9bbbbef5937a9601f9371e415c74ac9a7c --- M src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_N53.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/35317/1
diff --git a/src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_N53.c b/src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_N53.c index eba5747..dc5a2ac 100644 --- a/src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_N53.c +++ b/src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_N53.c @@ -22,11 +22,11 @@ .panel_bits_per_color = 8, .panel_bits_per_pixel = 24, .mode = { - .pixel_clock = 156297, + .pixel_clock = 159834, .lvds_dual_channel = 0, .refresh = 60, - .ha = 1200, .hbl = 164, .hso = 60, .hspw = 24, - .va = 1920, .vbl = 26, .vso = 14, .vspw = 2, + .ha = 1200, .hbl = 164, .hso = 114, .hspw = 10, + .va = 1920, .vbl = 33, .vso = 19, .vspw = 4, .phsync = '-', .pvsync = '-', .x_mm = 135, .y_mm = 216, },
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35317 )
Change subject: mediatek/mt8183: tune EDID for BOE panel ......................................................................
Patch Set 1: Code-Review+2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35317 )
Change subject: mediatek/mt8183: tune EDID for BOE panel ......................................................................
Patch Set 1:
+yuping - please include this in next squash / release.
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35317 )
Change subject: mediatek/mt8183: tune EDID for BOE panel ......................................................................
Patch Set 1: Code-Review+2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35317 )
Change subject: mediatek/mt8183: tune EDID for BOE panel ......................................................................
Patch Set 1:
Hi peichao, usually CL owner (in this case, you) don't +2 their own CLs. You have to wait for one more day before this can be merged.
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35317 )
Change subject: mediatek/mt8183: tune EDID for BOE panel ......................................................................
Patch Set 1: -Code-Review
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35317 )
Change subject: mediatek/mt8183: tune EDID for BOE panel ......................................................................
Patch Set 1:
Patch Set 1:
Hi peichao, usually CL owner (in this case, you) don't +2 their own CLs. You have to wait for one more day before this can be merged.
Dear Hung-te, copy that, thanks for your remind me.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35317 )
Change subject: mediatek/mt8183: tune EDID for BOE panel ......................................................................
Patch Set 1: Code-Review+1
Patch Set 1:
+yuping - please include this in next squash / release.
Got it.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35317 )
Change subject: mediatek/mt8183: tune EDID for BOE panel ......................................................................
mediatek/mt8183: tune EDID for BOE panel
BUG=b:140545315 TEST=builds Kodama image and verify display working properly
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I52a56f9bbbbef5937a9601f9371e415c74ac9a7c Reviewed-on: https://review.coreboot.org/c/coreboot/+/35317 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Hung-Te Lin hungte@chromium.org Reviewed-by: Yu-Ping Wu yupingso@google.com --- M src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_N53.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved Yu-Ping Wu: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_N53.c b/src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_N53.c index eba5747..dc5a2ac 100644 --- a/src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_N53.c +++ b/src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_N53.c @@ -22,11 +22,11 @@ .panel_bits_per_color = 8, .panel_bits_per_pixel = 24, .mode = { - .pixel_clock = 156297, + .pixel_clock = 159834, .lvds_dual_channel = 0, .refresh = 60, - .ha = 1200, .hbl = 164, .hso = 60, .hspw = 24, - .va = 1920, .vbl = 26, .vso = 14, .vspw = 2, + .ha = 1200, .hbl = 164, .hso = 114, .hspw = 10, + .va = 1920, .vbl = 33, .vso = 19, .vspw = 4, .phsync = '-', .pvsync = '-', .x_mm = 135, .y_mm = 216, },
-
Hung-Te Lin (Code Review) -
Patrick Georgi (Code Review)
-
Peichao Li (Code Review)
-
Yu-Ping Wu (Code Review)