Attention is currently required from: Frank Chu, Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62027 )
Change subject: mb/google/volteer/var/drobit: update default codec HID to 10EC5682
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/volteer/variants/drobit/variant.c:
https://review.coreboot.org/c/coreboot/+/62027/comment/e564a445_820d7647
PS2, Line 14: if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682I_VS)))
: config->hid = "RTL5682";
: else
: config->hid = "10EC5682";
I see, thanks for spelling it out. […]
I believe so, yes
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62027
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic37e7e6757476f1d30bea31fcde4deebebd488a5
Gerrit-Change-Number: 62027
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Attention: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Wed, 16 Feb 2022 23:58:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment