Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38824 )
Change subject: soc/intel/apollolake: Display platform information ......................................................................
Patch Set 5:
(7 comments)
https://review.coreboot.org/c/coreboot/+/38824/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38824/4//COMMIT_MSG@7 PS4, Line 7: apollolake
Not needed, as it’s in the prefix.
Done
https://review.coreboot.org/c/coreboot/+/38824/4//COMMIT_MSG@9 PS4, Line 9: apollolake
Apollo Lake
Done
https://review.coreboot.org/c/coreboot/+/38824/4//COMMIT_MSG@19 PS4, Line 19: Geminilake
It’s the successor of Apollo Lake.
Yes it is.
https://review.coreboot.org/c/coreboot/+/38824/4/src/soc/intel/apollolake/re... File src/soc/intel/apollolake/report_platform.c:
https://review.coreboot.org/c/coreboot/+/38824/4/src/soc/intel/apollolake/re... PS4, Line 79: u32 i
The counting variable should be just `unsigned int i`.
Done
https://review.coreboot.org/c/coreboot/+/38824/4/src/soc/intel/apollolake/re... PS4, Line 81: int vt, txt, aes;
Why not boolean type? Also, rename to `vt_supported`, and so on.
Done
https://review.coreboot.org/c/coreboot/+/38824/4/src/soc/intel/apollolake/re... PS4, Line 102: BIOS_DEBUG
I’d make that BIOS_INFO. […]
Done
https://review.coreboot.org/c/coreboot/+/38824/4/src/soc/intel/apollolake/re... PS4, Line 117: int
unsigned int
Done
-
Usha P (Code Review)