Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38944 )
Change subject: util/amdfwtool: Improve comment's grammar ......................................................................
util/amdfwtool: Improve comment's grammar
Reported by: Angel Pons Signed-off-by: Patrick Georgi pgeorgi@google.com
Change-Id: I2daa57c1982346e48dbd91a94864baf2f11c2129 --- M util/amdfwtool/amdfwtool.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/38944/1
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 522d332..379caaa 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -1439,7 +1439,7 @@
integrate_firmwares(&ctx, amd_romsig, amd_fw_table);
- ctx.current = ALIGN(ctx.current, 0x10000U); /* TODO: is necessary? */ + ctx.current = ALIGN(ctx.current, 0x10000U); /* TODO: is it necessary? */
if (multi) { /* Do 2nd PSP directory followed by 1st */
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38944 )
Change subject: util/amdfwtool: Improve comment's grammar ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38944 )
Change subject: util/amdfwtool: Improve comment's grammar ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38944/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38944/1//COMMIT_MSG@9 PS1, Line 9: Reported by: Angel Pons I think this is me? You can add my email, the one that's on sign-offs like CB:38853
https://review.coreboot.org/c/coreboot/+/38944/1//COMMIT_MSG@9 PS1, Line 9: Reported by Does this need a slash like all other tags?
https://review.coreboot.org/c/coreboot/+/38944/1//COMMIT_MSG@10 PS1, Line 10: Signed-off-by: Patrick Georgi pgeorgi@google.com Signed-off-by usually goes below the Change-Id line
Hello HAOUAS Elyes, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38944
to look at the new patch set (#2).
Change subject: util/amdfwtool: Improve comment's grammar ......................................................................
util/amdfwtool: Improve comment's grammar
Change-Id: I2daa57c1982346e48dbd91a94864baf2f11c2129 Signed-off-by: Patrick Georgi pgeorgi@google.com Reported-by: Angel Pons th3fanbus@gmail.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/38944/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38944 )
Change subject: util/amdfwtool: Improve comment's grammar ......................................................................
Patch Set 2: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/38944/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38944/1//COMMIT_MSG@9 PS1, Line 9: Reported by
Does this need a slash like all other tags?
Done
https://review.coreboot.org/c/coreboot/+/38944/1//COMMIT_MSG@9 PS1, Line 9: Reported by: Angel Pons
I think this is me? You can add my email, the one that's on sign-offs like CB:38853
Done
https://review.coreboot.org/c/coreboot/+/38944/1//COMMIT_MSG@10 PS1, Line 10: Signed-off-by: Patrick Georgi pgeorgi@google.com
Signed-off-by usually goes below the Change-Id line
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38944 )
Change subject: util/amdfwtool: Improve comment's grammar ......................................................................
util/amdfwtool: Improve comment's grammar
Change-Id: I2daa57c1982346e48dbd91a94864baf2f11c2129 Signed-off-by: Patrick Georgi pgeorgi@google.com Reported-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38944 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 522d332..379caaa 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -1439,7 +1439,7 @@
integrate_firmwares(&ctx, amd_romsig, amd_fw_table);
- ctx.current = ALIGN(ctx.current, 0x10000U); /* TODO: is necessary? */ + ctx.current = ALIGN(ctx.current, 0x10000U); /* TODO: is it necessary? */
if (multi) { /* Do 2nd PSP directory followed by 1st */
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38944 )
Change subject: util/amdfwtool: Improve comment's grammar ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/690 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/689 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/688
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)