Attention is currently required from: Tim Wawrzynczak. Malik Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55404 )
Change subject: mb/google/brya/variants/primus: set up gpio ......................................................................
Patch Set 1:
(5 comments)
Patchset:
PS1:
Latest schematics I found was 20210607B, is that accurate?
No, There is currently a newer version.
File src/mainboard/google/brya/variants/primus/gpio.c:
https://review.coreboot.org/c/coreboot/+/55404/comment/35e39ff2_f3430ef1 PS1, Line 24:
What about GPP_C3, GPP_C4 ?
These two pins were originally connected to the i219 LAN chip, but the LAN function has been removed, so these two pins are NC (same settings as the baseboard)
https://review.coreboot.org/c/coreboot/+/55404/comment/c12a208f_5933e912 PS1, Line 29: /* D6 : SRCCLKREQ1# ==> WWAN_SIM1_DET_ODL */
Isn't this NC?
Yes，this pin is NC. Done. Thanks.
https://review.coreboot.org/c/coreboot/+/55404/comment/edd68db5_88274c29 PS1, Line 40:
GPP_E10, GPP_E17?
Done. Thanks.
https://review.coreboot.org/c/coreboot/+/55404/comment/5d93578d_74c7c864 PS1, Line 50:
GPP_H21?
Done. Thanks.
-
Malik Hsu (Code Review)