Attention is currently required from: Ivy Jian, Karthik Ramasubramanian, Shelley Chen.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79295?usp=email )
Change subject: mb/google/brox: Update storage settings for SSD and UFS ......................................................................
Patch Set 3: Code-Review+1
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79295/comment/4bbce5f1_28d8caa4 : PS3, Line 10: configured configure
https://review.coreboot.org/c/coreboot/+/79295/comment/1a8327f1_7e5404c4 : PS3, Line 11: settings. … according to schematic <file name>.
https://review.coreboot.org/c/coreboot/+/79295/comment/7684e620_d1af52c2 : PS3, Line 16: unexpect unexpected
https://review.coreboot.org/c/coreboot/+/79295/comment/0008b696_9044c61c : PS3, Line 20: TEST=emerge-brox coreboot Don’t you have access yet?
File src/mainboard/google/brox/Kconfig:
https://review.coreboot.org/c/coreboot/+/79295/comment/ddd2a6db_facbf992 : PS3, Line 50: select DRIVERS_INTEL_ISH Maybe make that a separate commit.