Attention is currently required from: Hung-Te Lin, Martin Roth, JG Poxu.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52598 )
Change subject: soc/mediatek/mt8195: Add GPIO driver
......................................................................
Patch Set 2:
(2 comments)
File src/soc/mediatek/mt8195/include/soc/gpio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117548):
https://review.coreboot.org/c/coreboot/+/52598/comment/5876b35d_4386a2d1
PS2, Line 16: #define PIN(id, name, flag, bit, base, offset, \
Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117548):
https://review.coreboot.org/c/coreboot/+/52598/comment/15df425a_bdc5886b
PS2, Line 393: MSDC0_DAT6, RES2, RES3, RES4,RES5, RES6, RES7),
space required after that ',' (ctx:VxV)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52598
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica1b1c80a851075599442298bb6675caf5c72f57
Gerrit-Change-Number: 52598
Gerrit-PatchSet: 2
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: JG Poxu
jg_poxu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: JG Poxu
jg_poxu@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 22 Apr 2021 06:52:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment