Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29478 )
Change subject: device/i2c_bus: Add i2c_dev_readb_at_word()
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/29478/8/src/device/i2c_bus.c
File src/device/i2c_bus.c:
https://review.coreboot.org/c/coreboot/+/29478/8/src/device/i2c_bus.c@189
PS8, Line 189: transfer(busdev, msg, ARRAY_SIZE(msg));
Avoid multiple line dereference - prefer 'busdev->ops->ops_i2c_bus->transfer'
O_o
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29478
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7516f3e5d9aca362c2b340aa5627d91510c09412
Gerrit-Change-Number: 29478
Gerrit-PatchSet: 8
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 02 Sep 2019 14:06:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment