[L] Change in coreboot[main]: treewide: Change I2C/SMBUS master/slave to controller/target

[Martin L Roth (Code Review)]

Attention is currently required from: Arthur Heymans, Caveh Jalali, Cliff Huang, Felix Singer, Julius Werner, Matt DeVillier, Yidi Lin, Yu-Ping Wu.

Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77098?usp=email )

Change subject: treewide: Change I2C/SMBUS master/slave to controller/target
......................................................................

Patch Set 4:

(3 comments)

File src/southbridge/amd/pi/hudson/smbus_spd.c:

https://review.coreboot.org/c/coreboot/+/77098/comment/01b6061e_071efb86 :
PS3, Line 87: static int readspd(int iobase, int SmbusSlaveAddress, char *buffer, int count)
            : {
            : 	int index, error;
            : 
            : 	printk(BIOS_SPEW, "-------------READING SPD-----------\n");
            : 	printk(BIOS_SPEW, "iobase: 0x%08X, SmbusSlave: 0x%08X, count: %d\n",
            : 						iobase, SmbusSlaveAddress, count);
            : 
            : 	/* read the first byte using offset zero */
            : 	error = readSmbusByteData(iobase, SmbusSlaveAddress, buffer, 0);
            : 
            : 	if (error) {
            : 		printk(BIOS_ERR, "-------------SPD READ ERROR-----------\n");
            : 		return error;
            : 	}
            : 
            : 	/* read the remaining bytes using auto-increment for speed */
            : 	for (index = 1; index < count; index++)
            : 	{
            : 		error = readSmbusByte(iobase, SmbusSlaveAddress, &buffer [index]);
            : 		if (error) {
            : 			printk(BIOS_ERR, "-------------SPD READ ERROR-----------\n");
            : 			return error;
            : 		}
            : 	}
            : 	printk(BIOS_SPEW, "\n");
            : 	printk(BIOS_SPEW, "-------------FINISHED READING SPD-----------\n");
            : 
            : 	return 0;
            : }
> change `SmbusSlave*` to `SmbusTarget*` ?

Done

File src/southbridge/intel/bd82x6x/smbus.c:

https://review.coreboot.org/c/coreboot/+/77098/comment/defb3bde_9cf319dd :
PS3, Line 20: Slave
> Change to `Target` ?

Done

https://review.coreboot.org/c/coreboot/+/77098/comment/daf35a60_c903f29d :
PS3, Line 23: SMBUS_SLAVE_ADDR
> Change to `SMBUS_TARGET_ADDR` ?

This is from the chips' #define. I was asked not to update chip defines. Those should be changed only when the datasheet for the chip has been updated.