Attention is currently required from: Subrata Banik, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro, Karthik Ramasubramanian.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61114 )
Change subject: mb/google/brya: Apply fw_config_gpio_override API
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/brya/variants/anahera4es/fw_config.c:
https://review.coreboot.org/c/coreboot/+/61114/comment/a360a810_9a3205ee
PS8, Line 8: static const struct pad_config dmic_enable_pads[] = {
: PAD_CFG_NF(GPP_R4, NONE, DEEP, NF3), /* DMIC_CLK0 */
: PAD_CFG_NF(GPP_R5, NONE, DEEP, NF3), /* DMIC_DATA0 */
:
: };
:
:
Why did these arrays need to change from being constant structs? Because of the add_fw_override_pad […]
b/c this pad_info is not const. In order to apply one struct to all, so remove all the const. Being non const that we can change the baseboard array directly without memory allocate operation which Tim want to save.
struct pad_info {
struct pad_config *pads;
size_t pads_num;
};
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61114
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41fcfab197fd0d75bcefc68d8343e6e631fbeaba
Gerrit-Change-Number: 61114
Gerrit-PatchSet: 8
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 17 Feb 2022 03:47:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment