Attention is currently required from: Hung-Te Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85931?usp=email )
Change subject: soc/mediatek/common/dp: Use assert to check read/write API params
......................................................................
Patch Set 1:
(1 comment)
File src/soc/mediatek/common/dp/dptx_hal_common.c:
https://review.coreboot.org/c/coreboot/+/85931/comment/e13a42d5_072dd869?usp... :
PS1, Line 38: if (offset % 4 != 0 || offset > REG_OFFSET_LIMIT) {
: printk(BIOS_ERR, "[%s] invalid offset %#x for reg %p\n", __func__, offset,
: mtk_dp->regs);
: return;
: }
:
remove
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85931?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I94e6ad36d190d773876cbb43eb4ebe17164f3c92
Gerrit-Change-Number: 85931
Gerrit-PatchSet: 1
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Fri, 10 Jan 2025 07:09:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No