Attention is currently required from: Reka Norman, Maulik V Vaghela, Paul Menzel, Rizwan Qureshi, Subrata Banik, Sridhar Siricilla, Krishna P Bhat D, Usha P, Patrick Rudolph, Kangheui Won.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59751 )
Change subject: soc/intel/alderlake: Add Kconfig for ADL_N PCH
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
I'd prefer to squash this change into CB:59752 for simplicity.
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/59751/comment/ea6a9b8f_47f280b6
PS2, Line 6: config SOC_INTEL_ALDERLAKE_PCH_M
: bool
: help
: Choose this option if you have PCH-M chipset.
:
: config SOC_INTEL_ALDERLAKE_PCH_N
: bool
: help
: Choose this option if you have PCH-N chipset.
I'd like to have Kconfig options for all ADL PCH-x types. Besides these two, there's also PCH-P, which is currently chosen by omission (when not explicitly choosing any other PCH variant). I've made CB:59804 to implement this idea.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59751
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1be10aea36db5a14ca8d7cf5c087163e44554f78
Gerrit-Change-Number: 59751
Gerrit-PatchSet: 2
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Reka Norman
rekanorman@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Kangheui Won
khwon@google.com
Gerrit-Comment-Date: Wed, 01 Dec 2021 12:14:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment