Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/51041 )
Change subject: soc/amd/picasso/data_fabric: add missing data fabric device function 7 ......................................................................
soc/amd/picasso/data_fabric: add missing data fabric device function 7
The device function is missing in the PCI device table in the PPR, but is present in the hardware. Verified on a Mandolin board with PCO APU. The corresponding ticket for the PPR is DESPCSOC-6667.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ie91438bc905691d443ca4e7841549d1e3bca39ca --- M src/include/device/pci_ids.h M src/soc/amd/picasso/data_fabric.c 2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/51041/1
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index d6e0ee7..475d0a8 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -475,6 +475,7 @@ #define PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF4 0x15EC #define PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF5 0x15ED #define PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF6 0x15EE +#define PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF7 0x15EF #define PCI_DEVICE_ID_AMD_FAM17H_MODEL60H_DF0 0x1448 #define PCI_DEVICE_ID_AMD_FAM17H_MODEL60H_DF1 0x1449 #define PCI_DEVICE_ID_AMD_FAM17H_MODEL60H_DF2 0x144A diff --git a/src/soc/amd/picasso/data_fabric.c b/src/soc/amd/picasso/data_fabric.c index 982b7b2..700cb84 100644 --- a/src/soc/amd/picasso/data_fabric.c +++ b/src/soc/amd/picasso/data_fabric.c @@ -115,6 +115,8 @@ return "DFD5"; case PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF6: return "DFD6"; + case PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF7: + return "DFD7"; default: printk(BIOS_ERR, "%s: Unhandled device id 0x%x\n", __func__, dev->device); } @@ -137,6 +139,7 @@ PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF4, PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF5, PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF6, + PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF7, 0 };