Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60128 )
Change subject: mb/google/brya/variants/primus: remove board_id check for ALC5682I-VS ......................................................................
mb/google/brya/variants/primus: remove board_id check for ALC5682I-VS
The board ID check for audio codec is no longer required, therefore remove it.
BUG=b:210705216 TEST=emerge-brya coreboot chromeos-bootimage and check audio function
Signed-off-by: Malik_Hsu malik_hsu@wistron.corp-partner.google.com Change-Id: Ifbe838186da2e64737a9ffb557cf324124e79a9d Reviewed-on: https://review.coreboot.org/c/coreboot/+/60128 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: YH Lin yueherngl@google.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/brya/variants/primus/variant.c M src/mainboard/google/brya/variants/primus4es/variant.c 2 files changed, 4 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified YH Lin: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/brya/variants/primus/variant.c b/src/mainboard/google/brya/variants/primus/variant.c index 4c2458a..90999ec 100644 --- a/src/mainboard/google/brya/variants/primus/variant.c +++ b/src/mainboard/google/brya/variants/primus/variant.c @@ -17,14 +17,11 @@ emmc_rtd3->enabled = 0; }
-static void devtree_update_audio_codec(uint32_t board_ver) +static void devtree_update_audio_codec(void) { struct device *audio_codec = DEV_PTR(audio_codec); struct drivers_i2c_generic_config *config = audio_codec->chip_info;
- if (board_ver <= 1) - return; - if (fw_config_probe(FW_CONFIG(AUDIO, MAX98360_ALC5682I_VS_I2S))) config->hid = "RTL5682"; } @@ -58,5 +55,5 @@ uint32_t board_ver = board_id(); disable_unused_gpios(); devtree_update_emmc_rtd3(board_ver); - devtree_update_audio_codec(board_ver); + devtree_update_audio_codec(); } diff --git a/src/mainboard/google/brya/variants/primus4es/variant.c b/src/mainboard/google/brya/variants/primus4es/variant.c index 4c2458a..90999ec 100644 --- a/src/mainboard/google/brya/variants/primus4es/variant.c +++ b/src/mainboard/google/brya/variants/primus4es/variant.c @@ -17,14 +17,11 @@ emmc_rtd3->enabled = 0; }
-static void devtree_update_audio_codec(uint32_t board_ver) +static void devtree_update_audio_codec(void) { struct device *audio_codec = DEV_PTR(audio_codec); struct drivers_i2c_generic_config *config = audio_codec->chip_info;
- if (board_ver <= 1) - return; - if (fw_config_probe(FW_CONFIG(AUDIO, MAX98360_ALC5682I_VS_I2S))) config->hid = "RTL5682"; } @@ -58,5 +55,5 @@ uint32_t board_ver = board_id(); disable_unused_gpios(); devtree_update_emmc_rtd3(board_ver); - devtree_update_audio_codec(board_ver); + devtree_update_audio_codec(); }
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.