Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Pranava Y N, Rishika Raj.
Subrata Banik has posted comments on this change by Pranava Y N. ( https://review.coreboot.org/c/coreboot/+/83707?usp=email )
Change subject: mb/google/brya/var/nova: Remove USB Type-C port setting
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/nova/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83707/comment/0692d3f0_c7687a42?usp... :
PS1, Line 37:
we should keep other tcss ports also disable or empty? I guess there are 4 ports.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83707?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4b4025bea41f67224ac35ff2077b1394f2c3e380
Gerrit-Change-Number: 83707
Gerrit-PatchSet: 1
Gerrit-Owner: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Wed, 31 Jul 2024 15:14:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No