Attention is currently required from: Damien Zammit, Lee Leahy, Huang Jin, Arthur Heymans, Kyösti Mälkki, Andrey Petrov.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52933 )
Change subject: lib/romstage_handoff.c: Initialize using a cbmem hook
......................................................................
Patch Set 3:
(1 comment)
File src/lib/romstage_handoff.c:
https://review.coreboot.org/c/coreboot/+/52933/comment/8e22bb65_99b2196f
PS3, Line 56: ROMSTAGE_CBMEM_INIT_HOOK(romstage_handoff_init);
Since this file is compiled unconditionally, adding an INIT_HOOK() expands this to a lot of platforms which never used it. Please add a Kconfig to limit compilation of the file to the right set of boards if you want to do this (I'm not quite sure what exactly this is or what the right set of boards for it would be, but I know the Arm boards I work on don't use this, for example).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52933
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93abf33a6eb055eeaba1fed5042387822de1aa20
Gerrit-Change-Number: 52933
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Attention: Huang Jin
huang.jin@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Wed, 05 May 2021 22:13:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment