Attention is currently required from: Furquan Shaikh, Boris Mittelberg.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50567 )
Change subject: mb/google/brya: Enable cr50 support
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/50567/comment/d09f1387_fe51378a
PS1, Line 5:
: register "gpio_override_pm" = "1"
: register "gpio_pm[COMM_0]" = "0"
: register "gpio_pm[COMM_1]" = "0"
: register "gpio_pm[COMM_2]" = "0"
: register "gpio_pm[COMM_4]" = "0"
: register "gpio_pm[COMM_5]" = "0"
I think we are going to need the support like Volteer and Dedede to request cr50 to use long pulses. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50567
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80e27d0377960fb81f9149efb6f062d06432d40d
Gerrit-Change-Number: 50567
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Fri, 12 Feb 2021 20:08:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment