Bao Zheng has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45806 )
Change subject: amdfwtool: Remove the backup amdfwtool permanently ......................................................................
amdfwtool: Remove the backup amdfwtool permanently
Change-Id: Ic797e3b78d042dbc8a154670feef9f52f7c0c61d Signed-off-by: Zheng Bao zheng.bao@amd.com --- M Makefile.inc M util/amdfwtool/Makefile.inc 2 files changed, 2 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/45806/1
diff --git a/Makefile.inc b/Makefile.inc index 5cd7a64..bf33f8b 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -502,7 +502,7 @@ endif
additional-dirs := $(objutil)/cbfstool $(objutil)/ifdtool \ - $(objutil)/options $(objutil)/amdfwtool $(objutil)/amdfwtool-b \ + $(objutil)/options $(objutil)/amdfwtool \ $(objutil)/cbootimage
export $(COREBOOT_EXPORTS) @@ -576,7 +576,6 @@ cp -a $(top)/util/ifdtool/ifdtool $@
AMDFWTOOL:=$(objutil)/amdfwtool/amdfwtool -AMDFWTOOL-b:=$(objutil)/amdfwtool/amdfwtool-b
APCB_EDIT_TOOL:=$(top)/util/apcb/apcb_edit.py
@@ -678,7 +677,7 @@ include util/crossgcc/Makefile.inc
.PHONY: tools -tools: $(objutil)/kconfig/conf $(objutil)/kconfig/toada $(CBFSTOOL) $(objutil)/cbfstool/cbfs-compression-tool $(FMAPTOOL) $(RMODTOOL) $(IFWITOOL) $(objutil)/nvramtool/nvramtool $(objutil)/sconfig/sconfig $(IFDTOOL) $(CBOOTIMAGE) $(AMDFWTOOL) $(AMDFWTOOL-b) $(AMDCOMPRESS) $(FUTILITY) $(BINCFG) $(IFITTOOL) $(objutil)/supermicro/smcbiosinfo +tools: $(objutil)/kconfig/conf $(objutil)/kconfig/toada $(CBFSTOOL) $(objutil)/cbfstool/cbfs-compression-tool $(FMAPTOOL) $(RMODTOOL) $(IFWITOOL) $(objutil)/nvramtool/nvramtool $(objutil)/sconfig/sconfig $(IFDTOOL) $(CBOOTIMAGE) $(AMDFWTOOL) $(AMDCOMPRESS) $(FUTILITY) $(BINCFG) $(IFITTOOL) $(objutil)/supermicro/smcbiosinfo
########################################################################### # Common recipes for all stages diff --git a/util/amdfwtool/Makefile.inc b/util/amdfwtool/Makefile.inc index 139388b..18ad0d7 100644 --- a/util/amdfwtool/Makefile.inc +++ b/util/amdfwtool/Makefile.inc @@ -10,14 +10,3 @@ $(objutil)/amdfwtool/amdfwtool: $(addprefix $(objutil)/amdfwtool/,$(amdfwtoolobj)) printf " AMDFWTOOL\n" $(HOSTCC) $(addprefix $(objutil)/amdfwtool/,$(amdfwtoolobj)) -o $@ - -##### - -amdfwtoolobj-b = amdfwtool-b.o - -$(objutil)/amdfwtool/%.o: $(top)/util/amdfwtool/%.c # $(HEADER) - $(HOSTCC) $(AMDFWTOOLCFLAGS) $(HOSTCFLAGS) -DCONFIG_ROM_SIZE=$(CONFIG_ROM_SIZE) -c -o $@ $< - -$(objutil)/amdfwtool/amdfwtool-b: $(addprefix $(objutil)/amdfwtool/,$(amdfwtoolobj-b)) - printf " AMDFWTOOL-b\n" - $(HOSTCC) $(addprefix $(objutil)/amdfwtool/,$(amdfwtoolobj-b)) -o $@
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45806
to look at the new patch set (#5).
Change subject: amdfwtool: Remove the backup amdfwtool permanently ......................................................................
amdfwtool: Remove the backup amdfwtool permanently
Change-Id: Ic797e3b78d042dbc8a154670feef9f52f7c0c61d Signed-off-by: Zheng Bao zheng.bao@amd.com --- M Makefile.inc M util/amdfwtool/Makefile.inc 2 files changed, 2 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/45806/5
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45806 )
Change subject: amdfwtool: Remove the backup amdfwtool permanently ......................................................................
Patch Set 5:
this should also remove util/amdfwtool/amdfwtool-b.c. with the comment on the main patch of this series, this one might just become obsolete though
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45806 )
Change subject: amdfwtool: Remove the backup amdfwtool permanently ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45806/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45806/6//COMMIT_MSG@8 PS6, Line 8: Please add the motivation to the commit message.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45806 )
Change subject: amdfwtool: Remove the backup amdfwtool permanently ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45806/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45806/6//COMMIT_MSG@8 PS6, Line 8:
Please add the motivation to the commit message.
fyi: when the three patches before this one (big amdfwtool change and changes for stoneyridge and hudson) will be squashed into one patch, the copy of amdfwtool won't be needed, so this patch will become obsolete too
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45806
to look at the new patch set (#13).
Change subject: amdfwtool: Remove the backup amdfwtool permanently ......................................................................
amdfwtool: Remove the backup amdfwtool permanently
Change-Id: Ic797e3b78d042dbc8a154670feef9f52f7c0c61d Signed-off-by: Zheng Bao zheng.bao@amd.com --- M Makefile.inc M util/amdfwtool/Makefile.inc 2 files changed, 2 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/45806/13
Bao Zheng has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45806 )
Change subject: amdfwtool: Remove the backup amdfwtool permanently ......................................................................
Abandoned
useless now.
-
Bao Zheng (Code Review) -
Felix Held (Code Review)
-
Paul Menzel (Code Review)