Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58149 )
Change subject: soc/intel/*/me.c: Always print registers if me_state
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/alderlake/me.c:
https://review.coreboot.org/c/coreboot/+/58149/comment/cc23d749_b88703a9
PS1, Line 103: !cse_is_hfs1_cws_normal() ||
: !cse_is_hfs1_com_normal() ||
: !cse_is_hfs1_com_soft_temp_disable())
: return;
Oh sorry I misunderstood. […]
PCI interface gets changed once the ME is disabled, so I've changed it just to use me_state from CB:52800.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58149
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ad1215cceb75651b7890f3bab5df39b1b72ecf6
Gerrit-Change-Number: 58149
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 15 Oct 2021 06:29:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
admin@starlabs.systems
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment