Attention is currently required from: Kangheui Won, Reka Norman, Tim Wawrzynczak, Paul Menzel, Angel Pons, Arthur Heymans, Andrey Petrov.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67669 )
Change subject: drivers/intel/fsp2_0: Update MRC cache in ramstage
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67669/comment/b9d0241a_b134e5c4
PS1, Line 18:
Yeah, I found that too and considered adding it there. But it looks very generic, so I wasn't sure if we wanted to add platform-specific stuff to it.
Oh, nevermind, I somehow thought that was still in the FSP code. Yeah we probably don't want to put it there.
Patchset:
PS1:
Ok, sounds good. […]
Does anyone other than Chrome OS care about this? I would bet we're the only ones actually shipping ME_RW updates now. So if for us all the platforms that would be slower with the new flow all already branched, and we expect it to work fine on all future platforms, it should be okay.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67669
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6aa2dee83a3ab8913830746593935d36a034b8d
Gerrit-Change-Number: 67669
Gerrit-PatchSet: 1
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Tue, 20 Sep 2022 23:30:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment