Attention is currently required from: Tarun Tuli, Kapil Porwal.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73896 )
Change subject: mb/google/brya/variants/hades: Update GPU power sequencing to add Hades support ......................................................................
Patch Set 23: -Code-Review
(1 comment)
Patchset:
PS23: src/mainboard/google/brya/variants/hades/variant.c:58:14: error: use of undeclared identifier 'FBVDD_PWR_NEN' { "FBVDD", FBVDD_PWR_NEN, false, FBVDD_PG, }, ^ src/mainboard/google/brya/variants/hades/variant.c:114:25: error: invalid application of 'sizeof' to an incomplete type 'struct power_rail_sequence[]' for (size_t i = 0; i < ARRAY_SIZE(gpu_on_seq); i++) { ^~~~~~~~~~~~~~~~~~~~~~ src/commonlib/bsd/include/commonlib/bsd/helpers.h:12:30: note: expanded from macro 'ARRAY_SIZE' #define ARRAY_SIZE(a) (sizeof(a) / sizeof((a)[0]))