Attention is currently required from: Miriam Polzer, Andrey Pronin, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59097 )
Change subject: security/vboot: Add NVRAM counter for TPM 2.0
......................................................................
Patch Set 6:
(1 comment)
File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/59097/comment/a6247065_a71d0b6f
PS6, Line 120: TPMA_NV_WRITE_STCLEAR
No I didn't have this initially. Julius suggested to add it in case we need it at some later point.
I was just thinking it doesn't hurt? Is there ever a reason not to set this flag (just in case the need ever comes up in the future)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59097
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I511dba3b3461713ce20fb2bda9fced0fee6517e1
Gerrit-Change-Number: 59097
Gerrit-PatchSet: 6
Gerrit-Owner: Miriam Polzer
mpolzer@google.com
Gerrit-Reviewer: Andrey Pronin
apronin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Miriam Polzer
mpolzer@google.com
Gerrit-Attention: Andrey Pronin
apronin@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 17 Nov 2021 18:52:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Miriam Polzer
mpolzer@google.com
Comment-In-Reply-To: Andrey Pronin
apronin@chromium.org
Gerrit-MessageType: comment