Attention is currently required from: Felix Singer, Michael Niewöhner.
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69521 )
Change subject: mb/clevo/cml-u: Fix CMOS options ......................................................................
mb/clevo/cml-u: Fix CMOS options
The `hyper_threading` CMOS option was hooked up to the wrong enumeration and lacked a default value in `cmos.default`. Thus, use the correct enum for the `hyper_threading` option, remove the now-unused "backwards" enum and provide a default value in `cmos.default`.
Change-Id: I56b0320f9210cde8ff58db176d2b7d2207c98aa9 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/clevo/cml-u/cmos.default M src/mainboard/clevo/cml-u/cmos.layout 2 files changed, 17 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/69521/1
diff --git a/src/mainboard/clevo/cml-u/cmos.default b/src/mainboard/clevo/cml-u/cmos.default index a20f1b1..098bfa6 100644 --- a/src/mainboard/clevo/cml-u/cmos.default +++ b/src/mainboard/clevo/cml-u/cmos.default @@ -1,5 +1,6 @@ boot_option=Fallback debug_level=Debug +hyper_threading=Enable power_on_after_fail=Disable
# EC options diff --git a/src/mainboard/clevo/cml-u/cmos.layout b/src/mainboard/clevo/cml-u/cmos.layout index 391deb1..8350704 100644 --- a/src/mainboard/clevo/cml-u/cmos.layout +++ b/src/mainboard/clevo/cml-u/cmos.layout @@ -17,7 +17,7 @@
# ----------------------------------------------------------------- # coreboot config options: cpu -400 1 e 2 hyper_threading +400 1 e 1 hyper_threading
# ----------------------------------------------------------------- # coreboot config options: southbridge @@ -52,8 +52,6 @@ #ID value text 1 0 Disable 1 1 Enable -2 0 Enable -2 1 Disable 4 0 Fallback 4 1 Normal 6 0 Emergency