Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50528 )
Change subject: soc/intel: Remove unused <console/console.h> ......................................................................
soc/intel: Remove unused <console/console.h>
Change-Id: I630b7b0b1d564bcd99358caaaef4afd78c22866c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/50528 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/alderlake/uart.c M src/soc/intel/apollolake/elog.c M src/soc/intel/apollolake/uart.c M src/soc/intel/baytrail/elog.c M src/soc/intel/braswell/elog.c M src/soc/intel/braswell/sata.c M src/soc/intel/braswell/scc.c M src/soc/intel/broadwell/pch/elog.c M src/soc/intel/cannonlake/smihandler.c M src/soc/intel/cannonlake/uart.c M src/soc/intel/elkhartlake/romstage/fsp_params.c M src/soc/intel/elkhartlake/smihandler.c M src/soc/intel/elkhartlake/uart.c M src/soc/intel/icelake/smihandler.c M src/soc/intel/icelake/uart.c M src/soc/intel/jasperlake/smihandler.c M src/soc/intel/jasperlake/uart.c M src/soc/intel/skylake/elog.c M src/soc/intel/skylake/graphics.c M src/soc/intel/skylake/uart.c M src/soc/intel/tigerlake/chip.c M src/soc/intel/tigerlake/smihandler.c M src/soc/intel/tigerlake/uart.c M src/soc/intel/xeon_sp/skx/romstage.c 24 files changed, 0 insertions(+), 24 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/soc/intel/alderlake/uart.c b/src/soc/intel/alderlake/uart.c index 06618b2..e1a77b3 100644 --- a/src/soc/intel/alderlake/uart.c +++ b/src/soc/intel/alderlake/uart.c @@ -6,7 +6,6 @@ * Chapter number: 9 */
-#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/gpio.h> #include <intelblocks/lpss.h> diff --git a/src/soc/intel/apollolake/elog.c b/src/soc/intel/apollolake/elog.c index 47b68f1..1f65040 100644 --- a/src/soc/intel/apollolake/elog.c +++ b/src/soc/intel/apollolake/elog.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <acpi/acpi_pm.h> -#include <console/console.h> #include <device/pci_type.h> #include <elog.h> #include <intelblocks/pmclib.h> diff --git a/src/soc/intel/apollolake/uart.c b/src/soc/intel/apollolake/uart.c index 2a2d7a2..b8758f5 100644 --- a/src/soc/intel/apollolake/uart.c +++ b/src/soc/intel/apollolake/uart.c @@ -6,7 +6,6 @@ * shouldn't cause any fragmentation. */
-#include <console/console.h> #include <intelblocks/uart.h> #include <soc/gpio.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/baytrail/elog.c b/src/soc/intel/baytrail/elog.c index b299c37..b49c7c8 100644 --- a/src/soc/intel/baytrail/elog.c +++ b/src/soc/intel/baytrail/elog.c @@ -2,7 +2,6 @@
#include <acpi/acpi.h> #include <acpi/acpi_pm.h> -#include <console/console.h> #include <device/device.h> #include <device/pci.h> #include <elog.h> diff --git a/src/soc/intel/braswell/elog.c b/src/soc/intel/braswell/elog.c index b299c37..b49c7c8 100644 --- a/src/soc/intel/braswell/elog.c +++ b/src/soc/intel/braswell/elog.c @@ -2,7 +2,6 @@
#include <acpi/acpi.h> #include <acpi/acpi_pm.h> -#include <console/console.h> #include <device/device.h> #include <device/pci.h> #include <elog.h> diff --git a/src/soc/intel/braswell/sata.c b/src/soc/intel/braswell/sata.c index d80edec..d88ee57 100644 --- a/src/soc/intel/braswell/sata.c +++ b/src/soc/intel/braswell/sata.c @@ -3,7 +3,6 @@ #include <soc/pci_devs.h> #include <soc/ramstage.h> #include <soc/sata.h> -#include <console/console.h> #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/soc/intel/braswell/scc.c b/src/soc/intel/braswell/scc.c index c6d4f52..902ee57 100644 --- a/src/soc/intel/braswell/scc.c +++ b/src/soc/intel/braswell/scc.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <acpi/acpi_gnvs.h> -#include <console/console.h> #include <device/device.h> #include <device/pci.h> #include <soc/iosf.h> diff --git a/src/soc/intel/broadwell/pch/elog.c b/src/soc/intel/broadwell/pch/elog.c index 3f62556..789b4e8 100644 --- a/src/soc/intel/broadwell/pch/elog.c +++ b/src/soc/intel/broadwell/pch/elog.c @@ -2,7 +2,6 @@
#include <acpi/acpi_pm.h> #include <bootstate.h> -#include <console/console.h> #include <stdint.h> #include <elog.h> #include <soc/lpc.h> diff --git a/src/soc/intel/cannonlake/smihandler.c b/src/soc/intel/cannonlake/smihandler.c index dd8db5b..bfee1c0 100644 --- a/src/soc/intel/cannonlake/smihandler.c +++ b/src/soc/intel/cannonlake/smihandler.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <device/device.h> #include <intelblocks/cse.h> #include <intelblocks/smihandler.h> diff --git a/src/soc/intel/cannonlake/uart.c b/src/soc/intel/cannonlake/uart.c index cc44a61..da0306c 100644 --- a/src/soc/intel/cannonlake/uart.c +++ b/src/soc/intel/cannonlake/uart.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/gpio.h> #include <intelblocks/lpss.h> diff --git a/src/soc/intel/elkhartlake/romstage/fsp_params.c b/src/soc/intel/elkhartlake/romstage/fsp_params.c index 50add6e..f6c59a6 100644 --- a/src/soc/intel/elkhartlake/romstage/fsp_params.c +++ b/src/soc/intel/elkhartlake/romstage/fsp_params.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <assert.h> -#include <console/console.h> #include <device/device.h> #include <fsp/util.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/elkhartlake/smihandler.c b/src/soc/intel/elkhartlake/smihandler.c index 7d2a15e..6637847 100644 --- a/src/soc/intel/elkhartlake/smihandler.c +++ b/src/soc/intel/elkhartlake/smihandler.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/cse.h> #include <intelblocks/smihandler.h> diff --git a/src/soc/intel/elkhartlake/uart.c b/src/soc/intel/elkhartlake/uart.c index cc44a61..da0306c 100644 --- a/src/soc/intel/elkhartlake/uart.c +++ b/src/soc/intel/elkhartlake/uart.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/gpio.h> #include <intelblocks/lpss.h> diff --git a/src/soc/intel/icelake/smihandler.c b/src/soc/intel/icelake/smihandler.c index fbbbbdb..2ca2816 100644 --- a/src/soc/intel/icelake/smihandler.c +++ b/src/soc/intel/icelake/smihandler.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/cse.h> #include <intelblocks/smihandler.h> diff --git a/src/soc/intel/icelake/uart.c b/src/soc/intel/icelake/uart.c index cc44a61..da0306c 100644 --- a/src/soc/intel/icelake/uart.c +++ b/src/soc/intel/icelake/uart.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/gpio.h> #include <intelblocks/lpss.h> diff --git a/src/soc/intel/jasperlake/smihandler.c b/src/soc/intel/jasperlake/smihandler.c index 6d31adf..448c053 100644 --- a/src/soc/intel/jasperlake/smihandler.c +++ b/src/soc/intel/jasperlake/smihandler.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/cse.h> #include <intelblocks/smihandler.h> diff --git a/src/soc/intel/jasperlake/uart.c b/src/soc/intel/jasperlake/uart.c index cc44a61..da0306c 100644 --- a/src/soc/intel/jasperlake/uart.c +++ b/src/soc/intel/jasperlake/uart.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/gpio.h> #include <intelblocks/lpss.h> diff --git a/src/soc/intel/skylake/elog.c b/src/soc/intel/skylake/elog.c index d325a93..c6be670 100644 --- a/src/soc/intel/skylake/elog.c +++ b/src/soc/intel/skylake/elog.c @@ -3,7 +3,6 @@ #include <acpi/acpi_pm.h> #include <bootstate.h> #include <commonlib/helpers.h> -#include <console/console.h> #include <device/mmio.h> #include <device/pci_ops.h> #include <stdint.h> diff --git a/src/soc/intel/skylake/graphics.c b/src/soc/intel/skylake/graphics.c index d41c4aa..786ba2d 100644 --- a/src/soc/intel/skylake/graphics.c +++ b/src/soc/intel/skylake/graphics.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <commonlib/helpers.h> -#include <console/console.h> #include <device/mmio.h> #include <device/pci_rom.h> #include <device/resource.h> diff --git a/src/soc/intel/skylake/uart.c b/src/soc/intel/skylake/uart.c index 4235788..6eb8c3f 100644 --- a/src/soc/intel/skylake/uart.c +++ b/src/soc/intel/skylake/uart.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <device/pci_def.h> #include <gpio.h> #include <intelblocks/lpss.h> diff --git a/src/soc/intel/tigerlake/chip.c b/src/soc/intel/tigerlake/chip.c index 8be04b6..4aa818e 100644 --- a/src/soc/intel/tigerlake/chip.c +++ b/src/soc/intel/tigerlake/chip.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <device/device.h> #include <device/pci.h> #include <fsp/api.h> diff --git a/src/soc/intel/tigerlake/smihandler.c b/src/soc/intel/tigerlake/smihandler.c index 40ed25e..67d21f8 100644 --- a/src/soc/intel/tigerlake/smihandler.c +++ b/src/soc/intel/tigerlake/smihandler.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/cse.h> #include <intelblocks/smihandler.h> diff --git a/src/soc/intel/tigerlake/uart.c b/src/soc/intel/tigerlake/uart.c index a3aee39..da392f4 100644 --- a/src/soc/intel/tigerlake/uart.c +++ b/src/soc/intel/tigerlake/uart.c @@ -6,7 +6,6 @@ * Chapter number: 9 */
-#include <console/console.h> #include <device/pci_def.h> #include <intelblocks/gpio.h> #include <intelblocks/lpss.h> diff --git a/src/soc/intel/xeon_sp/skx/romstage.c b/src/soc/intel/xeon_sp/skx/romstage.c index a1c370d..a5c78f6 100644 --- a/src/soc/intel/xeon_sp/skx/romstage.c +++ b/src/soc/intel/xeon_sp/skx/romstage.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <arch/romstage.h> -#include <console/console.h> #include <intelblocks/rtc.h> #include <soc/romstage.h> #include <soc/soc_util.h>
-
Kyösti Mälkki (Code Review)