Attention is currently required from: Subrata Banik, Matt DeVillier, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63210 )
Change subject: drivers/i2c/dw_i2c: Add detect callback to i2c_bus_ops ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63210/comment/cc3df3cc_8351cdea PS1, Line 12: 0-byte Do most devices handle this correctly?
File src/drivers/i2c/designware/dw_i2c.c:
https://review.coreboot.org/c/coreboot/+/63210/comment/a18ffdb0_84b922a3 PS1, Line 492: bus Check the return value
https://review.coreboot.org/c/coreboot/+/63210/comment/2e5aae6c_ef57772d PS1, Line 544: dw_i2c_disable Can an interrupt sneak in between the clear and disable? Should we disable before clearing?
How much time do we spend enabling and disabling?
-
Raul Rangel (Code Review)