Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45387 )
Change subject: nb/intel/pineview: Move register headers into a subfolder ......................................................................
nb/intel/pineview: Move register headers into a subfolder
Move all files with register definitions into a `registers` subfolder.
Tested with BUILD_TIMELESS=1, Foxconn D41S remains identical.
Change-Id: Icc3df9fa43ac3858a8b177491020295804b17aa3 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/pineview/pineview.h R src/northbridge/intel/pineview/registers/host_bridge.h R src/northbridge/intel/pineview/registers/mchbar.h 3 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/45387/1
diff --git a/src/northbridge/intel/pineview/pineview.h b/src/northbridge/intel/pineview/pineview.h index 03fa318..aacaad5 100644 --- a/src/northbridge/intel/pineview/pineview.h +++ b/src/northbridge/intel/pineview/pineview.h @@ -19,7 +19,7 @@ /* Device 0:0.0 PCI configuration space (Host Bridge) */ #define HOST_BRIDGE PCI_DEV(0, 0, 0)
-#include "hostbridge_regs.h" +#include "registers/host_bridge.h"
/* Device 0:1.0 PCI configuration space (PCI Express) */
@@ -53,7 +53,7 @@
/* As there are many registers, define them on a separate file */
-#include "mchbar_regs.h" +#include "registers/mchbar.h"
/* * EPBAR - Egress Port Root Complex Register Block diff --git a/src/northbridge/intel/pineview/hostbridge_regs.h b/src/northbridge/intel/pineview/registers/host_bridge.h similarity index 88% rename from src/northbridge/intel/pineview/hostbridge_regs.h rename to src/northbridge/intel/pineview/registers/host_bridge.h index 506efcf..fbdcfea 100644 --- a/src/northbridge/intel/pineview/hostbridge_regs.h +++ b/src/northbridge/intel/pineview/registers/host_bridge.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
-#ifndef __PINEVIEW_HOSTBRIDGE_REGS_H__ -#define __PINEVIEW_HOSTBRIDGE_REGS_H__ +#ifndef __PINEVIEW_REGISTERS_HOST_BRIDGE_H__ +#define __PINEVIEW_REGISTERS_HOST_BRIDGE_H__
#define EPBAR 0x40 #define MCHBAR 0x48 @@ -54,4 +54,4 @@ #define MID0 0xf8 #define DEBUP0 0xfc
-#endif /* __PINEVIEW_HOSTBRIDGE_REGS_H__ */ +#endif /* __PINEVIEW_REGISTERS_HOST_BRIDGE_H__ */ diff --git a/src/northbridge/intel/pineview/mchbar_regs.h b/src/northbridge/intel/pineview/registers/mchbar.h similarity index 98% rename from src/northbridge/intel/pineview/mchbar_regs.h rename to src/northbridge/intel/pineview/registers/mchbar.h index e9cd7ce..1339135 100644 --- a/src/northbridge/intel/pineview/mchbar_regs.h +++ b/src/northbridge/intel/pineview/registers/mchbar.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#ifndef __PINEVIEW_MCHBAR_REGS_H__ -#define __PINEVIEW_MCHBAR_REGS_H__ +#ifndef __PINEVIEW_REGISTERS_MCHBAR_H__ +#define __PINEVIEW_REGISTERS_MCHBAR_H__
/* Indexed register helper macros */ #define Gz(r, z) ((r) + ((z) * 0x100)) @@ -562,4 +562,4 @@ #define EXTTSCS 0x3825 #define C0THRMSTS 0x3830
-#endif /* __PINEVIEW_MCHBAR_REGS_H__ */ +#endif /* __PINEVIEW_REGISTERS_MCHBAR_H__ */
Hello build bot (Jenkins), Damien Zammit, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45387
to look at the new patch set (#3).
Change subject: nb/intel/pineview: Move register headers into a subfolder ......................................................................
nb/intel/pineview: Move register headers into a subfolder
Move all files with register definitions into a `registers` subfolder.
Tested with BUILD_TIMELESS=1, Foxconn D41S remains identical.
Change-Id: Icc3df9fa43ac3858a8b177491020295804b17aa3 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/pineview/pineview.h R src/northbridge/intel/pineview/registers/host_bridge.h R src/northbridge/intel/pineview/registers/mchbar.h 3 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/45387/3
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45387 )
Change subject: nb/intel/pineview: Move register headers into a subfolder ......................................................................
Abandoned