Attention is currently required from: Julius Werner. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50247 )
Change subject: Documentation: Codify some guidelines for headers and chain-including ......................................................................
Patch Set 2:
(1 comment)
File Documentation/coding_style.md:
https://review.coreboot.org/c/coreboot/+/50247/comment/02053f6f_adc72305 PS2, Line 840: Headers should always be included at the top of the file
I personally believe that, for specific files, it makes more sense to not include everything at the […]
And in some files, the header can't be included at the top:
https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/baytrail/ac...
Despite that, I think the expectation is that headers will be at the top of the file.
It's kind of like driving, in that doing the expected thing is more important than doing the nice thing. Waving at someone to turn first is nice, but can lead to confusion, delays, and accidents. Having code that conforms to expectations helps everyone work on it together and should? result in fewer bugs.