Attention is currently required from: Hung-Te Lin, Paul Menzel.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61330 )
Change subject: soc/mediatek/mt8186: Update PWRAP arbiter enable bit
......................................................................
Patch Set 5:
(1 comment)
File src/soc/mediatek/mt8186/include/soc/pmic_wrap.h:
https://review.coreboot.org/c/coreboot/+/61330/comment/b3b6722f_3ef23307
PS4, Line 366: ARB_WACS2 = 0x1 << 2,
I’d prefer this scheme, but if you convert to BIT, please do it in a separate commit.
Thanks for your review.
I have change to 1 << x and use BIT in another patch:
https://review.coreboot.org/c/coreboot/+/61351
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61330
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I324d18fa5d3cd745c35fcf0f207e1b444b5e898b
Gerrit-Change-Number: 61330
Gerrit-PatchSet: 5
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 25 Jan 2022 01:59:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment