Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/3189 )
Change subject: sconfig: Refuse devicetree with leaf "chip"s
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/3189/1/util/sconfig/sconfig.y
File util/sconfig/sconfig.y:
https://review.coreboot.org/c/coreboot/+/3189/1/util/sconfig/sconfig.y@37
PS1, Line 37: chipchildren: chipchildren device | device | chipchildren chip | chipchildren registers ;
the | is a separator, and we don't _want_ to allow the empty substitution anymore. […]
Thanks a lot for the explanation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/3189
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia35b518bd4acd631e78bdf63c4424c0fa6a81229
Gerrit-Change-Number: 3189
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Mon, 04 May 2020 13:48:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment