Attention is currently required from: Bao Zheng, Julius Werner, Maximilian Brune, Paul Menzel, Zheng Bao.
Felix Held has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84338?usp=email )
Change subject: amdfwtool: Check fletcher of each header
......................................................................
Patch Set 7:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/84338/comment/de3e3572_e660a28d?usp... :
PS1, Line 571: default: /* ISH */
Done
hm, i'd add a bool is_ish_dir as second parameter to this function to account for the ISH case and check if that's true and do the ISH table checksum check and return that result in that case before the switch case. sure, if the ISH had a cookie like the other tables this would make things a bit nicer, but introducing that additional parameter seems to be the best solution where we can be sure that nothing might be identified as the wrong table
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84338?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7540386027c6449317e9b7c0b4fd22d09d4a3a3
Gerrit-Change-Number: 84338
Gerrit-PatchSet: 7
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Tue, 14 Jan 2025 20:11:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de