Attention is currently required from: ChiaLing, Paul Menzel, Reka Norman, Ryan Lin, Zhuohao Lee.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75396?usp=email )
Change subject: mb/google/dedede: Support variant specific power limits
......................................................................
Patch Set 11:
(2 comments)
File src/mainboard/google/dedede/variants/baseboard/ramstage.c:
https://review.coreboot.org/c/coreboot/+/75396/comment/0de791d1_0208e908 :
PS10, Line 134:
Pl4 will be 60w. It updated on CB:75395.
On brask, we set PL4 to the same value as psyspl2 for Type-C, i.e. limit it to 97% of the charger rating. Do we need to do the same here? Currently PL4 will currently exceed the charger rating for 45W chargers.
File src/mainboard/google/dedede/variants/baseboard/ramstage.c:
https://review.coreboot.org/c/coreboot/+/75396/comment/a540a3c8_6464539b :
PS11, Line 106: psyspl1,
not used
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75396?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If38a9b7923f19885f6d47b83c92b68ef6dfa88db
Gerrit-Change-Number: 75396
Gerrit-PatchSet: 11
Gerrit-Owner: ChiaLing
chia-ling.hou@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ryan Lin
ryan.lin@intel.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@google.com
Gerrit-CC: Super Ni
super.ni@intel.com
Gerrit-CC: Super Ni
super.ni@intel.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Ryan Lin
ryan.lin@intel.com
Gerrit-Attention: ChiaLing
chia-ling.hou@intel.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Fri, 02 Jun 2023 01:16:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ChiaLing
chia-ling.hou@intel.com
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Gerrit-MessageType: comment