Attention is currently required from: Raul Rangel, Martin Roth.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52113 )
Change subject: mb/google/guybrush: Enable backlight in the OS
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/guybrush/mainboard.c:
https://review.coreboot.org/c/coreboot/+/52113/comment/e24a0fc3_8015a6f3
PS4, Line 14:
Missing a tab?
I think it's just displaying weird. OTHO, it seems odd to have tabs on l.14 but spaces in 15-19.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52113
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e0a6c06120ac5abf0a0d82494e03d9cf80c1f8c
Gerrit-Change-Number: 52113
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Thu, 15 Apr 2021 19:46:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment