Attention is currently required from: Shelley Chen, Ravi kumar, Furquan Shaikh, Julius Werner, mturney mturney. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53902 )
Change subject: sc7280: Add PCIe RC driver in coreboot ......................................................................
Patch Set 62:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/53902/comment/2088cfd8_4fa9542c PS62, Line 9: initialize initializes
https://review.coreboot.org/c/coreboot/+/53902/comment/64a400ed_10160a8e PS62, Line 9: ram stage ramstage
https://review.coreboot.org/c/coreboot/+/53902/comment/7c527b06_856e89b8 PS62, Line 10: QMP PHY and does and …: something missing?
https://review.coreboot.org/c/coreboot/+/53902/comment/2cb01078_8414ddb7 PS62, Line 11: EP(NVMe) 1. EP (NVMe) 2. What is EP?
https://review.coreboot.org/c/coreboot/+/53902/comment/cae2bb2a_c8b48140 PS62, Line 12: set sets
https://review.coreboot.org/c/coreboot/+/53902/comment/c2a3ac0a_d35fc799 PS62, Line 9: In coreboot ram stage, PCIe root complex driver initialize : the PCIe core, QMP PHY and does the bus enumeration. : Upon successful detection of EP(NVMe), PCIe RC driver : allocates the resources and set the configuration parameters. Please reflow for 72 characters per line.
-
Paul Menzel (Code Review)