Michael Niewöhner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35458 )
Change subject: mb/supermicro/x11ssh-tf: correct CBFS_SIZE ......................................................................
mb/supermicro/x11ssh-tf: correct CBFS_SIZE
The specified CBFS_SIZE does not make sense. The boards BIOS region is 0xb00000. Correct the value.
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: Ia3014c7fd081030607790ced6bb55323086f1161 --- M src/mainboard/supermicro/x11ssh/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/35458/1
diff --git a/src/mainboard/supermicro/x11ssh/Kconfig b/src/mainboard/supermicro/x11ssh/Kconfig index e6f342d..dcf6bb9 100644 --- a/src/mainboard/supermicro/x11ssh/Kconfig +++ b/src/mainboard/supermicro/x11ssh/Kconfig @@ -34,7 +34,7 @@
config CBFS_SIZE hex - default 0x009aa000 if !VBOOT + default 0xb00000
config IRQ_SLOT_COUNT int
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35458 )
Change subject: mb/supermicro/x11ssh-tf: correct CBFS_SIZE ......................................................................
Patch Set 1: Code-Review+2
Hello Patrick Rudolph, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35458
to look at the new patch set (#2).
Change subject: mb/supermicro/x11ssh-tf: correct CBFS_SIZE ......................................................................
mb/supermicro/x11ssh-tf: correct CBFS_SIZE
The specified CBFS_SIZE does not make sense. The boards BIOS region is 0xb00000. Correct the value.
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: Ia3014c7fd081030607790ced6bb55323086f1161 --- M src/mainboard/supermicro/x11ssh/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/35458/2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35458 )
Change subject: mb/supermicro/x11ssh-tf: correct CBFS_SIZE ......................................................................
mb/supermicro/x11ssh-tf: correct CBFS_SIZE
The specified CBFS_SIZE does not make sense. The boards BIOS region is 0xb00000. Correct the value.
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: Ia3014c7fd081030607790ced6bb55323086f1161 Reviewed-on: https://review.coreboot.org/c/coreboot/+/35458 Reviewed-by: Patrick Rudolph siro@das-labor.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/supermicro/x11ssh/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/mainboard/supermicro/x11ssh/Kconfig b/src/mainboard/supermicro/x11ssh/Kconfig index e6f342d..dcf6bb9 100644 --- a/src/mainboard/supermicro/x11ssh/Kconfig +++ b/src/mainboard/supermicro/x11ssh/Kconfig @@ -34,7 +34,7 @@
config CBFS_SIZE hex - default 0x009aa000 if !VBOOT + default 0xb00000
config IRQ_SLOT_COUNT int
-
Michael Niewöhner (Code Review) -
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)