Hello Anjaneya "Reddy" Chagam,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/40925
to review the following change.
Change subject: Documentation/mb/ocp/tiogapass: Add documentation ......................................................................
Documentation/mb/ocp/tiogapass: Add documentation
Add OCP platform TiogaPass documentation.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Signed-off-by: Reddy Chagam anjaneya.chagam@intel.com Change-Id: If4c2832d5bd006c572dab035040b4242f8a3d53b --- A Documentation/mainboard/ocp/tiogapass.md M MAINTAINERS 2 files changed, 105 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/40925/1
diff --git a/Documentation/mainboard/ocp/tiogapass.md b/Documentation/mainboard/ocp/tiogapass.md new file mode 100644 index 0000000..33c5e10 --- /dev/null +++ b/Documentation/mainboard/ocp/tiogapass.md @@ -0,0 +1,95 @@ +# OCP TiogaPass + +This page describes coreboot support status for the OCP (Open Compute Project) +TiogaPass server platform. + +## Introduction + +OCP TiogaPass server platform was contributed by Facebook, and was accepted +in 2019. The design collatoral including datasheet can be found at [OCP TiogaPass]. + +Since complete EE design collaboral is open sourced, anyone can build a variant +based on the original design. It can also be purchased from [OCP Market Place]. +An off-the-shelf version is available, as well as rack ready version. With the +off-the-shelf version, the server can be plugged into wall power outlet. + +With the off-the-shelf version of TiogaPass, a complete software solution is +available. [Off-the-shelf Host Firmware] takes the approach of UEFI/Linuxboot. + +Coreboot as of release 4.13 is a proof-of-concept project between Facebook, +Intel, Wiwynn and Quanta. More context can be referenced at [OCP TiogaPass POC Blog]. +## Required blobs + +This board currently requires: +fsp blob - The blob is not available to the public. The binary is at POC +status, hopefully there is a IBV stepping up to maintain the binary. +Microcode - 3rdparty/intel-microcode/intel-ucode/06-55-04 +ME binary - The binary can be extracted from [Off-the-shelf Host Firmware]. +Linuxboot binary - This is optional. U-root as initramfs, is used in the POC +activity. It can be extracted from [Off-the-shelf Host Firmware], or it can be +built according to [All about u-root]. + +## Flashing coreboot + +### Internal programming + +Using [flashrom] is not verified. + +### External programming + +From OpenBMC, to update FW image: +fw-util mb --force --update <path to coreboot image> + +To power off/on the host: +power-util mb off +power-util mb on + +To connect to console through SOL (Serial Over Lan): +sol-util mb + +## Known issues / feature gaps +- c6 state is not supported. Workaround is to disable c6 support through +target OS and Linuxboot kernel paramter. +- SMI handlers are not implemented. +- xSDT tables are not fully populated, such as processor/socket devices, +PCIe bridge devices. +- There is boot stability issue. +- If [CB 40500 patchset] is not merged, when PCIe riser card is used, +boot fails. +- PCIe devices connected to socket 1 may not work, due to FSP issue. +- Some TiogaPass SKUs do not have all PCIe devices working. +- SMBIOS type 7 and type 17 are not populated. + +- None + +## Working +- Most SMBIOS types. +- BMC integration: +-- BMC readiness check +-- IPMI commands +-- watchdog timer +-- POST complete pin acknowledgement. +- SEL record generation. +- Early serial output. +- port 80h direct to GPIO. +- ACPI tables: APIC/DMAR/DSDT/FACP/FACS/HPET/MCFG/SPMI/SRAT/SLIT/SSDT. + +## Technology + +```eval_rst ++------------------+--------------------------------------------------+ +| SoC (2 sockets) | Intel SkyLake Scalable Processor LGA3647 | ++------------------+--------------------------------------------------+ +| BMC | Aspeed 2500 | ++------------------+--------------------------------------------------+ +| PCH | Intel Lewisburg C620 | ++------------------+--------------------------------------------------+ +``` + +[flashrom]: https://flashrom.org/Flashrom +[OCP TiogaPass]: https://www.opencompute.org/contributions?query=Tioga%20Pass%20v1.0 +[OCP Market Place]: https://www.opencompute.org/products/109/wiwynn-tioga-pass-advanced-2u-ocp-s... +[Off-the-shelf Host Firmware]: https://github.com/linuxboot/book/blob/master/case_studies/TiogaPass/README.... +[OCP TiogaPass POC Blog]: https://www.opencompute.org/blog/linux-firmware-boots-up-server-powered-by-i... +[All about u-root]: https://github.com/linuxboot/book/tree/master/u-root +[CB 40500 patchset]: https://review.coreboot.org/c/coreboot/+/40500 diff --git a/MAINTAINERS b/MAINTAINERS index bc1e1fc..3531292 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -362,6 +362,16 @@ S: Maintained F: src/mainboard/facebook/monolith/
+OCP TIOGAPASS MAINBOARD +M: Jonathan Zhang jonzhang@fb.com +M: Reddy Chagam anjaneya.chagam@intel.com +M: Johnny Lin Johnny_Lin@wiwynn.com +M: Morgan Jang Morgan_Jang@wiwynn.com +M: Ryback Hung <Ryback.Hung@quantatw.com +M: Bryant Ou Bryant.Ou@quantatw.com +S: Maintained +F: src/mainboard/ocp/tiogapass + PORTWELL PQ-M107 MAINBOARD M: Frans Hendriks fhendriks@eltan.com M: Wim Vervoorn wvervoorn@eltan.com
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Documentation/mb/ocp/tiogapass: Add documentation ......................................................................
Patch Set 1:
This change is ready for review.
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Documentation/mb/ocp/tiogapass: Add documentation ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 85: C620 С621?
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Documentation/mb/ocp/tiogapass: Add documentation ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40925/1/MAINTAINERS File MAINTAINERS:
https://review.coreboot.org/c/coreboot/+/40925/1/MAINTAINERS@365 PS1, Line 365: OCP TIOGAPASS MAINBOARD Make a new patch for this
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Documentation/mb/ocp/tiogapass: Add documentation ......................................................................
Patch Set 1:
(17 comments)
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 3: OCP (Open Compute Project) : TiogaPass server Add a link for OCP Web site or the server platform?
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 9: collatoral Learnt a new meaning: https://www.merriam-webster.com/dictionary/collateral. Thanks. ;-)
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 11: collaboral collatoral?
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 21: ## Required blobs Add a space above?
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 26: Microcode - Use one space instead of the tab?
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 26: 3rdparty/intel-microcode/intel-ucode/06-55-04 Mark up as code with `…`?
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 41: fw-util mb --force --update <path to coreboot image> Please indent with four spaces to mark it up as a code block.
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 44: power-util mb off : power-util mb on Ditto.
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 48: sol-util mb Ditto.
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 52: target OS and Linuxboot kernel paramter. Please list it here. `processor.max_cstate`?
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 56: - There is boot stability issue. Please give more detail.
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 63: - None ???
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 65: ## Working Please list first, what payload (with version) and Linux version you used for testing.
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 66: - Most SMBIOS types. Please remove dot/period at the end.
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 68: -- BMC readiness check Does that convert correctly in Markdown? Indent with four spaces and use one -?
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 71: -- POST complete pin acknowledgement. No dot/period at the end (also below).
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 81: SkyLake Skylake
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Documentation/mb/ocp/tiogapass: Add documentation ......................................................................
Patch Set 1:
(18 comments)
Thanks for the review!
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 3: OCP (Open Compute Project) : TiogaPass server
Add a link for OCP Web site or the server platform?
Done
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 9: collatoral
Learnt a new meaning: https://www.merriam-webster.com/dictionary/collateral. Thanks. […]
Thanks for your review!
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 11: collaboral
collatoral?
Done
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 21: ## Required blobs
Add a space above?
Done
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 26: Microcode -
Use one space instead of the tab?
Done
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 26: 3rdparty/intel-microcode/intel-ucode/06-55-04
Mark up as code with `…`?
Done
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 41: fw-util mb --force --update <path to coreboot image>
Please indent with four spaces to mark it up as a code block.
Done
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 44: power-util mb off : power-util mb on
Ditto.
Done
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 48: sol-util mb
Ditto.
Done
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 52: target OS and Linuxboot kernel paramter.
Please list it here. `processor. […]
Done
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 56: - There is boot stability issue.
Please give more detail.
Done
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 63: - None
???
Done
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 65: ## Working
Please list first, what payload (with version) and Linux version you used for testing.
Done
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 66: - Most SMBIOS types.
Please remove dot/period at the end.
Done
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 68: -- BMC readiness check
Does that convert correctly in Markdown? Indent with four spaces and use one -?
Done
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 71: -- POST complete pin acknowledgement.
No dot/period at the end (also below).
Done
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 81: SkyLake
Skylake
Done
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 85: C620
С621?
Done
Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Patrick Georgi, Patrick Rudolph, Ryback Hung, Johnny Lin, David Hendricks, Morgan Jang, Bryant Ou, Andrey Petrov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40925
to look at the new patch set (#2).
Change subject: Documentation/mb/ocp/tiogapass: Add documentation ......................................................................
Documentation/mb/ocp/tiogapass: Add documentation
Add OCP platform TiogaPass documentation.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Signed-off-by: Reddy Chagam anjaneya.chagam@intel.com Change-Id: If4c2832d5bd006c572dab035040b4242f8a3d53b --- A Documentation/mainboard/ocp/tiogapass.md 1 file changed, 100 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/40925/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Documentation/mb/ocp/tiogapass: Add documentation ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40925/2/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/2/Documentation/mainboard/ocp... PS2, Line 19: Coreboot as of release 4.13 is a proof-of-concept project between Facebook, coreboot needs to be spelled lowercase. The builder warns about it:
Documentation/mainboard/ocp/tiogapass.md:19:Coreboot as of release 4.13 is a proof-of-concept project between Facebook,
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Documentation/mb/ocp/tiogapass: Add documentation ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40925/2/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/2/Documentation/mainboard/ocp... PS2, Line 1: # OCP TiogaPass document needs to be referenced from existing .md
https://review.coreboot.org/c/coreboot/+/40925/2/Documentation/mainboard/ocp... PS2, Line 54: target OS and Linuxboot kernel paramter, such as "cpuidle.off=1". ident with two spaces to continue the item
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Documentation/mb/ocp/tiogapass: Add documentation ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40925/2/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/2/Documentation/mainboard/ocp... PS2, Line 1: # OCP TiogaPass
document needs to be referenced from existing . […]
Done
https://review.coreboot.org/c/coreboot/+/40925/2/Documentation/mainboard/ocp... PS2, Line 19: Coreboot as of release 4.13 is a proof-of-concept project between Facebook,
coreboot needs to be spelled lowercase. The builder warns about it: […]
Done
https://review.coreboot.org/c/coreboot/+/40925/2/Documentation/mainboard/ocp... PS2, Line 54: target OS and Linuxboot kernel paramter, such as "cpuidle.off=1".
ident with two spaces to continue the item
Done
Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Patrick Georgi, Patrick Rudolph, Ryback Hung, Johnny Lin, David Hendricks, Morgan Jang, Bryant Ou, Andrey Petrov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40925
to look at the new patch set (#3).
Change subject: Documentation/mb/ocp/tiogapass: Add documentation ......................................................................
Documentation/mb/ocp/tiogapass: Add documentation
Add OCP platform TiogaPass documentation.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Signed-off-by: Reddy Chagam anjaneya.chagam@intel.com Change-Id: If4c2832d5bd006c572dab035040b4242f8a3d53b --- M Documentation/mainboard/index.md A Documentation/mainboard/ocp/tiogapass.md 2 files changed, 104 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/40925/3
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Documentation/mb/ocp/tiogapass: Add documentation ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40925/2/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/2/Documentation/mainboard/ocp... PS2, Line 54: target OS and Linuxboot kernel paramter, such as "cpuidle.off=1".
Done
It looks better, but it’s not needed.
https://pandoc.org/try/?text=Test%0A%3D%3D%3D%3D%0A%0A-+This+starts%0Auiaend...
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Documentation/mb/ocp/tiogapass: Add documentation ......................................................................
Patch Set 3:
(8 comments)
https://review.coreboot.org/c/coreboot/+/40925/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40925/3//COMMIT_MSG@7 PS3, Line 7: Documentation Doc
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 26: priviledge privilege
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 30: Linuxboot binary You can compile that from source. It's not a blob.
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 38: not verified Huh?
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 42: OpenBMC If you are using the BMC to flash coreboot, that is considered internal programming. External programming consists of connecting something like a Dediprog SF600 and flashing with that.
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 85: SoC Why not call it CPU or processor? Intel uses "Processor":
https://ark.intel.com/content/www/us/en/ark/products/series/125191/intel-xeo...
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 87: 2500 AST2500
https://review.coreboot.org/c/coreboot/+/40925/1/MAINTAINERS File MAINTAINERS:
https://review.coreboot.org/c/coreboot/+/40925/1/MAINTAINERS@365 PS1, Line 365: OCP TIOGAPASS MAINBOARD
Make a new patch for this
Done
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Documentation/mb/ocp/tiogapass: Add documentation ......................................................................
Patch Set 3:
(7 comments)
https://review.coreboot.org/c/coreboot/+/40925/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40925/3//COMMIT_MSG@7 PS3, Line 7: Documentation
Doc
Done
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 26: priviledge
privilege
Done
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 30: Linuxboot binary
You can compile that from source. It's not a blob.
I did not want to imply it is a blob. I changed the wording from "binary" to "image".
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 38: not verified
Huh?
Yes, we have not tried to run flashrom tool from OS.
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 42: OpenBMC
If you are using the BMC to flash coreboot, that is considered internal programming. […]
Done. Oh, okay, so Out-Of-Band is part of internal programming. Since there is nothing special about external programming, I removed this section.
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 85: SoC
Why not call it CPU or processor? Intel uses "Processor": […]
Done
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 87: 2500
AST2500
Done
Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Patrick Georgi, Patrick Rudolph, Ryback Hung, Johnny Lin, David Hendricks, Morgan Jang, Bryant Ou, Andrey Petrov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40925
to look at the new patch set (#4).
Change subject: Doc/mb/ocp: Add documentation for Tiogapass ......................................................................
Doc/mb/ocp: Add documentation for Tiogapass
Add OCP platform Tiogapass documentation.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Signed-off-by: Reddy Chagam anjaneya.chagam@intel.com Change-Id: If4c2832d5bd006c572dab035040b4242f8a3d53b --- M Documentation/mainboard/index.md A Documentation/mainboard/ocp/tiogapass.md 2 files changed, 100 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/40925/4
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Doc/mb/ocp: Add documentation for Tiogapass ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 30: Linuxboot binary
You can compile that from source. It's not a blob. […]
It would be nice to move it into its own section, and out of the "Required blobs" section. Maybe add a new "LinuxBoot" section?
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 38: not verified
Yes, we have not tried to run flashrom tool from OS.
Right. Would be nice to test it, if possible.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Doc/mb/ocp: Add documentation for Tiogapass ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 30: Linuxboot binary
It would be nice to move it into its own section, and out of the "Required blobs" section. […]
Makes sense. I added a "Payload" section.
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 38: not verified
Right. Would be nice to test it, if possible.
Yes, we will test it in coming months.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Doc/mb/ocp: Add documentation for Tiogapass ......................................................................
Patch Set 5: Code-Review+1
The LinuxBoot information could be moved into separate section in a follow-up.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Doc/mb/ocp: Add documentation for Tiogapass ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 38: not verified
Yes, we will test it in coming months.
Tested, it works.
Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Patrick Georgi, Patrick Rudolph, Ryback Hung, Johnny Lin, Paul Menzel, David Hendricks, Morgan Jang, Bryant Ou, Andrey Petrov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40925
to look at the new patch set (#6).
Change subject: Doc/mb/ocp: Add documentation for Tiogapass ......................................................................
Doc/mb/ocp: Add documentation for Tiogapass
Add OCP platform Tiogapass documentation.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Signed-off-by: Reddy Chagam anjaneya.chagam@intel.com Change-Id: If4c2832d5bd006c572dab035040b4242f8a3d53b --- M Documentation/mainboard/index.md A Documentation/mainboard/ocp/tiogapass.md 2 files changed, 104 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/40925/6
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Doc/mb/ocp: Add documentation for Tiogapass ......................................................................
Patch Set 6: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ind... File Documentation/mainboard/index.md:
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ind... PS6, Line 117: Tiogapass Tioga Pass
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp... PS6, Line 1: TiogaPass Tioga Pass
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp... PS6, Line 4: TiogaPass same - replace everywhere please.
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp... PS6, Line 9: [OCP TiogaPass] You can also provide the link directly in the test wit [Description](link)
Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Patrick Georgi, Patrick Rudolph, Ryback Hung, Johnny Lin, Christian Walter, Paul Menzel, David Hendricks, Morgan Jang, Bryant Ou, Andrey Petrov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40925
to look at the new patch set (#7).
Change subject: Doc/mb/ocp: Add documentation for Tioga Pass ......................................................................
Doc/mb/ocp: Add documentation for Tioga Pass
Add OCP platform Tioga Pass documentation.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Signed-off-by: Reddy Chagam anjaneya.chagam@intel.com Change-Id: If4c2832d5bd006c572dab035040b4242f8a3d53b --- M Documentation/mainboard/index.md A Documentation/mainboard/ocp/tiogapass.md 2 files changed, 104 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/40925/7
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Doc/mb/ocp: Add documentation for Tioga Pass ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ind... File Documentation/mainboard/index.md:
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ind... PS6, Line 117: Tiogapass
Tioga Pass
Done
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp... PS6, Line 1: TiogaPass
Tioga Pass
Done
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp... PS6, Line 4: TiogaPass
same - replace everywhere please.
Done
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp... PS6, Line 9: [OCP TiogaPass]
You can also provide the link directly in the test wit [Description](link)
Could you elaborate? Thanks.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Doc/mb/ocp: Add documentation for Tioga Pass ......................................................................
Patch Set 7: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Doc/mb/ocp: Add documentation for Tioga Pass ......................................................................
Patch Set 7: Code-Review+1
Please also upload the logs to the board status repository with `util/board_status/board_status.sh`.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Doc/mb/ocp: Add documentation for Tioga Pass ......................................................................
Patch Set 7: Code-Review+1
(8 comments)
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp... PS6, Line 9: [OCP TiogaPass]
Could you elaborate? Thanks.
I think it's good enough as it currently is.
https://review.coreboot.org/c/coreboot/+/40925/7/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/7/Documentation/mainboard/ocp... PS7, Line 9: collatoral collateral
https://review.coreboot.org/c/coreboot/+/40925/7/Documentation/mainboard/ocp... PS7, Line 11: collatoral collateral
https://review.coreboot.org/c/coreboot/+/40925/7/Documentation/mainboard/ocp... PS7, Line 25: fsp Uppercase: FSP
https://review.coreboot.org/c/coreboot/+/40925/7/Documentation/mainboard/ocp... PS7, Line 26: some day someday
https://review.coreboot.org/c/coreboot/+/40925/7/Documentation/mainboard/ocp... PS7, Line 38: updae update
https://review.coreboot.org/c/coreboot/+/40925/7/Documentation/mainboard/ocp... PS7, Line 53: c6 Uppercase: C6
https://review.coreboot.org/c/coreboot/+/40925/7/Documentation/mainboard/ocp... PS7, Line 53: c6 C6
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Doc/mb/ocp: Add documentation for Tioga Pass ......................................................................
Patch Set 7:
(8 comments)
Patch Set 7: Code-Review+1
Please also upload the logs to the board status repository with `util/board_status/board_status.sh`.
Yes, let me do that!
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp... PS6, Line 9: [OCP TiogaPass]
I think it's good enough as it currently is.
Ack
https://review.coreboot.org/c/coreboot/+/40925/7/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/7/Documentation/mainboard/ocp... PS7, Line 9: collatoral
collateral
Done
https://review.coreboot.org/c/coreboot/+/40925/7/Documentation/mainboard/ocp... PS7, Line 11: collatoral
collateral
Done
https://review.coreboot.org/c/coreboot/+/40925/7/Documentation/mainboard/ocp... PS7, Line 25: fsp
Uppercase: FSP
Done
https://review.coreboot.org/c/coreboot/+/40925/7/Documentation/mainboard/ocp... PS7, Line 26: some day
someday
Done
https://review.coreboot.org/c/coreboot/+/40925/7/Documentation/mainboard/ocp... PS7, Line 38: updae
update
Done
https://review.coreboot.org/c/coreboot/+/40925/7/Documentation/mainboard/ocp... PS7, Line 53: c6
Uppercase: C6
Done
https://review.coreboot.org/c/coreboot/+/40925/7/Documentation/mainboard/ocp... PS7, Line 53: c6
C6
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Doc/mb/ocp: Add documentation for Tioga Pass ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp... PS6, Line 1: TiogaPass
Done
Forgot to push the updated version?
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Doc/mb/ocp: Add documentation for Tioga Pass ......................................................................
Patch Set 7:
Patch Set 7:
(8 comments)
Patch Set 7: Code-Review+1
Please also upload the logs to the board status repository with `util/board_status/board_status.sh`.
Yes, let me do that!
Thank you for uploading it [1].
1. coreboot logs are missing, as CBMEM console is disabled. 2. The timestamps look quite confusing. 3. Do you know, why the revisions in the logs are marked dirty?
[1]: https://review.coreboot.org/cgit/board-status.git/tree/ocp/tiogapass/4.12-59...
Hello build bot (Jenkins), Patrick Georgi, Patrick Rudolph, Ryback Hung, Paul Menzel, Angel Pons, Andrey Petrov, Patrick Rudolph, Anjaneya "Reddy" Chagam, Johnny Lin, Christian Walter, David Hendricks, Morgan Jang, Bryant Ou,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40925
to look at the new patch set (#8).
Change subject: Doc/mb/ocp: Add documentation for Tioga Pass ......................................................................
Doc/mb/ocp: Add documentation for Tioga Pass
Add OCP platform Tioga Pass documentation.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Signed-off-by: Reddy Chagam anjaneya.chagam@intel.com Change-Id: If4c2832d5bd006c572dab035040b4242f8a3d53b --- M Documentation/mainboard/index.md A Documentation/mainboard/ocp/tiogapass.md 2 files changed, 104 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/40925/8
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Doc/mb/ocp: Add documentation for Tioga Pass ......................................................................
Patch Set 8:
(1 comment)
Patch Set 7:
Patch Set 7:
(8 comments)
Patch Set 7: Code-Review+1
Please also upload the logs to the board status repository with `util/board_status/board_status.sh`.
Yes, let me do that!
Thank you for uploading it [1].
- coreboot logs are missing, as CBMEM console is disabled.
We will enable CBMEM console.
- The timestamps look quite confusing.
I am not sure why. This needs to be investigated.
- Do you know, why the revisions in the logs are marked dirty?
Because of submodules (in paticular 3rdparty/libgfxinit). I will need to sort this out.
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp... PS6, Line 1: TiogaPass
Forgot to push the updated version?
Sorry, Angel. I did forget.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Doc/mb/ocp: Add documentation for Tioga Pass ......................................................................
Patch Set 8: Code-Review+1
Patch Set 8:
Patch Set 7:
- Do you know, why the revisions in the logs are marked dirty?
Because of submodules (in paticular 3rdparty/libgfxinit). I will need to sort this out.
You can run `make gitconfig` and `git sup`, then all submodules are updated accordinf to the hash stored in coreboot’s repository.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Doc/mb/ocp: Add documentation for Tioga Pass ......................................................................
Patch Set 8: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp... PS6, Line 1: TiogaPass
Sorry, Angel. I did forget.
Thanks!
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Doc/mb/ocp: Add documentation for Tioga Pass ......................................................................
Doc/mb/ocp: Add documentation for Tioga Pass
Add OCP platform Tioga Pass documentation.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Signed-off-by: Reddy Chagam anjaneya.chagam@intel.com Change-Id: If4c2832d5bd006c572dab035040b4242f8a3d53b Reviewed-on: https://review.coreboot.org/c/coreboot/+/40925 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com --- M Documentation/mainboard/index.md A Documentation/mainboard/ocp/tiogapass.md 2 files changed, 104 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/Documentation/mainboard/index.md b/Documentation/mainboard/index.md index a31148c..c5503e2 100644 --- a/Documentation/mainboard/index.md +++ b/Documentation/mainboard/index.md @@ -116,6 +116,10 @@
- [MS-7707](msi/ms7707/ms7707.md)
+## OCP + +- [Tioga Pass](ocp/tiogapass.md) + ## Open Cellular
- [Elgon](opencellular/elgon.md) diff --git a/Documentation/mainboard/ocp/tiogapass.md b/Documentation/mainboard/ocp/tiogapass.md new file mode 100644 index 0000000..6d6afb1 --- /dev/null +++ b/Documentation/mainboard/ocp/tiogapass.md @@ -0,0 +1,100 @@ +# OCP Tioga Pass + +This page describes coreboot support status for the [OCP] (Open Compute Project) +Tioga Pass server platform. + +## Introduction + +OCP Tioga Pass server platform was contributed by Facebook, and was accepted +in 2019. The design collateral including datasheet can be found at [OCP Tioga Pass]. + +Since complete EE design collateral is open sourced, anyone can build server +as-is or a variant based on the original design. It can also be purchased from [OCP Market Place]. +An off-the-shelf version is available, as well as rack ready version. With the +off-the-shelf version, the server can be plugged into wall power outlet. + +With the off-the-shelf version of Tioga Pass, a complete software solution is +available. [Off-the-shelf Host Firmware] takes the approach of UEFI/Linuxboot. + +coreboot as of release 4.13 is a proof-of-concept project between Facebook, +Intel, Wiwynn and Quanta. The context is described at [OCP Tioga Pass POC Blog]. + +## Required blobs + +This board currently requires: +- FSP blob: The blob (Intel Skylake Scalable Processor Firmware Support Package) + is not yet available to the public. The binary is at POC status, hopefully + someday an IBV is able to obtain the privilege to maintain it. +- Microcode: `3rdparty/intel-microcode/intel-ucode/06-55-04` +- ME binary: The binary can be extracted from [Off-the-shelf Host Firmware]. + +## Payload +- Linuxboot: This is necessary only if you use Linuxboot as coreboot payload. + U-root as initramfs, is used in the POC activity. It can be extracted from + [Off-the-shelf Host Firmware], or it can be built following [All about u-root]. + +## Flashing coreboot + +To do in-band FW image update, use [flashrom]: + flashrom -p internal:ich_spi_mode=hwseq -c "Opaque flash chip" --ifd \ + -i bios --noverify-all -w <path to coreboot image> + +From OpenBMC, to update FW image: + fw-util mb --force --update <path to coreboot image> + +To power off/on the host: + power-util mb off + power-util mb on + +To connect to console through SOL (Serial Over Lan): + sol-util mb + +## Known issues / feature gaps +- C6 state is not supported. Workaround is to disable C6 support through + target OS and Linuxboot kernel paramter, such as "cpuidle.off=1". +- SMI handlers are not implemented. +- xSDT tables are not fully populated, such as processor/socket devices, + PCIe bridge devices. +- There is boot stability issue. Occasionally the boot hangs at ramstage + with following message "BIOS PCU Misc Config Read timed out." +- If [CB 40500 patchset] is not merged, when PCIe riser card is used, + boot fails. +- PCIe devices connected to socket 1 may not work, because FSP + does not support PCIe topology input for socket 1.k +- SMBIOS type 7 and type 17 are not populated. + +## Working +The solution was developed using Linuxboot payload. The Linuxboot +kernel versions tried are 4.16.18 and 5.2.9. The initramfs image is +u-root. +- Most SMBIOS types +- BMC integration: + - BMC readiness check + - IPMI commands + - watchdog timer + - POST complete pin acknowledgement +- SEL record generation +- Early serial output +- port 80h direct to GPIO +- ACPI tables: APIC/DMAR/DSDT/FACP/FACS/HPET/MCFG/SPMI/SRAT/SLIT/SSDT + +## Technology + +```eval_rst ++------------------------+---------------------------------------------+ +| Processor (2 sockets) | Intel Skylake Scalable Processor LGA3647 | ++------------------------+---------------------------------------------+ +| BMC | Aspeed AST 2500 | ++------------------------+---------------------------------------------+ +| PCH | Intel Lewisburg C621 | ++------------------------+---------------------------------------------+ +``` + +[flashrom]: https://flashrom.org/Flashrom +[OCP]: https://www.opencompute.org/ +[OCP Tioga Pass]: https://www.opencompute.org/contributions?query=Tioga%20Pass%20v1.0 +[OCP Market Place]: https://www.opencompute.org/products/109/wiwynn-tioga-pass-advanced-2u-ocp-s... +[Off-the-shelf Host Firmware]: https://github.com/linuxboot/book/blob/master/case_studies/TiogaPass/README.... +[OCP Tioga Pass POC Blog]: https://www.opencompute.org/blog/linux-firmware-boots-up-server-powered-by-i... +[All about u-root]: https://github.com/linuxboot/book/tree/master/u-root +[CB 40500 patchset]: https://review.coreboot.org/c/coreboot/+/40500