[M] Change in coreboot[master]: soc/amd/mendocino: Enhance DPTC_INPUT to support 13 DPTC thermal para...

[EricKY Cheng (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, Matt DeVillier, Tim Van Patten, Fred Reitberger, Felix Held.

EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68649 )

Change subject: soc/amd/mendocino: Enhance DPTC_INPUT to support 13 DPTC thermal parameters
......................................................................

Patch Set 22:

(2 comments)

File src/soc/amd/mendocino/root_complex.c:

https://review.coreboot.org/c/coreboot/+/68649/comment/216303b6_f2a3d3d7 
PS16, Line 393: #else
> I will keep the current design and fill out  src/mainboard/google/skyrim/variants/skyrim/overridetre […]

Hi all,

If it is OK for adding below setting on src/mainboard/google/skyrim/variants/skyrim/overridetree.cb.

config->vrm_current_limit_throttle_mA,
config->vrm_maximum_current_limit_throttle_mA,
config->vrm_soc_current_limit_throttle_mA,

BR,
Eric KY Cheng

File src/soc/amd/mendocino/root_complex.c:

https://review.coreboot.org/c/coreboot/+/68649/comment/b5707553_b9f8a9b7 
PS20, Line 269: 	/* Normal mode DPTC values. */
              : 	struct dptc_input default_input = DPTC_INPUTS(
              : 		config->thermctl_limit_degreeC,
              : 		config->sustained_power_limit_mW,
              : 		config->slow_ppt_time_constant_s,
              : 		config->fast_ppt_limit_mW,
              : 		config->slow_ppt_limit_mW,
              : 		config->vrm_current_limit_mA,
              : 		config->vrm_maximum_current_limit_mA,
              : 		config->vrm_soc_current_limit_mA,
              : 		config->stt_min_limit,
              : 		config->stt_m1,
              : 		config->stt_m2,
              : 		config->stt_c_apu,
              : 		config->stt_skin_temp_apu);
              : 	acpigen_write_alib_dptc_default((uint8_t *)&default_input, sizeof(default_input));
              : 
              : 	/* Low/No Battery */
              : 	struct dptc_input no_battery_input = DPTC_INPUTS(
              : 		config->thermctl_limit_degreeC,
              : 		config->sustained_power_limit_mW,
              : 		config->slow_ppt_time_constant_s,
              : 		config->fast_ppt_limit_mW,
              : 		config->slow_ppt_limit_mW,
              : 		config->vrm_current_limit_throttle_mA,
              : 		config->vrm_maximum_current_limit_throttle_mA,
              : 		config->vrm_soc_current_limit_throttle_mA,
              : 		config->stt_min_limit,
              : 		config->stt_m1,
              : 		config->stt_m2,
              : 		config->stt_c_apu,
              : 		config->stt_skin_temp_apu);
              : 	acpigen_write_alib_dptc_no_battery((uint8_t *)&no_battery_input,
              : 		sizeof(no_battery_input));
> default_input on line 270 is different form default_input on line 395. […]

Done