Attention is currently required from: Paz Zcharya.
Subrata Banik has posted comments on this change by Paz Zcharya. ( https://review.coreboot.org/c/coreboot/+/86566?usp=email )
Change subject: refactor: Consolidate bmp_logo_filename() logic ......................................................................
Patch Set 1:
(1 comment)
File src/lib/bmp_logo.c:
https://review.coreboot.org/c/coreboot/+/86566/comment/f41f21f9_1fcf1eee?usp... : PS1, Line 37: if (platform_is_low_battery_shutdown_needed()) : logo_name = "low_battery.bmp"; This existed to allow low-battery rendering by non-ChromeOS devices as well. Since there's no relation between low-battery and ChromeOS vendor code, the reviewers suggested keeping the low-battery logo inside bmp_logo.c, while the ChromeOS splash screen is ChromeOS-specific code that should be in the vendor code.