Rizwan Qureshi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39922 )
Change subject: soc/intel/common/block: Add missing include ......................................................................
soc/intel/common/block: Add missing include
include types.h in src/soc/intel/common/block/include/intelblocks/cse.h to use type bool.
without this build issues may be observed if types.h is not included by some other file in the chain. like in https://qa.coreboot.org/job/coreboot-gerrit/121064/console
Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com Change-Id: I92ee533bca7dc255f7a341b2a68bbc09900996a1 --- M src/soc/intel/common/block/include/intelblocks/cse.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/39922/1
diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h index 2c81383..ead5d41 100644 --- a/src/soc/intel/common/block/include/intelblocks/cse.h +++ b/src/soc/intel/common/block/include/intelblocks/cse.h @@ -17,6 +17,7 @@ #define SOC_INTEL_COMMON_CSE_H
#include <stdint.h> +#include <types.h>
/* MKHI Command groups */ #define MKHI_GROUP_ID_CBM 0x0
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39922 )
Change subject: soc/intel/common/block: Add missing include ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39922/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39922/2//COMMIT_MSG@9 PS2, Line 9: include Include
https://review.coreboot.org/c/coreboot/+/39922/2//COMMIT_MSG@12 PS2, Line 12: without Without
https://review.coreboot.org/c/coreboot/+/39922/2//COMMIT_MSG@14 PS2, Line 14: like in https://qa.coreboot.org/job/coreboot-gerrit/121064/console The URL will get invalid after the build artifects are deleted.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39922 )
Change subject: soc/intel/common/block: Add missing include ......................................................................
Patch Set 2: Code-Review+1
Hello build bot (Jenkins), Wonkyu Kim, Sridhar Siricilla, Subrata Banik, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39922
to look at the new patch set (#3).
Change subject: soc/intel/common/block: Add missing include ......................................................................
soc/intel/common/block: Add missing include
Include types.h in src/soc/intel/common/block/include/intelblocks/cse.h to use type bool.
Without this, there can be a build error like below,
src/soc/intel/common/block/include/intelblocks/cse.h:208:1: error: unknown type name 'bool'; did you mean '_Bool'? bool cse_is_hfs1_com_soft_temp_disable(void); ^~~~ _Bool src/soc/intel/common/block/include/intelblocks/cse.h:214:1: error: unknown type name 'bool'; did you mean '_Bool'? bool cse_is_hfs3_fw_sku_custom(void);
Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com Change-Id: I92ee533bca7dc255f7a341b2a68bbc09900996a1 --- M src/soc/intel/common/block/include/intelblocks/cse.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/39922/3
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39922 )
Change subject: soc/intel/common/block: Add missing include ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39922/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39922/2//COMMIT_MSG@9 PS2, Line 9: include
Include
Done
https://review.coreboot.org/c/coreboot/+/39922/2//COMMIT_MSG@12 PS2, Line 12: without
Without
Done
https://review.coreboot.org/c/coreboot/+/39922/2//COMMIT_MSG@14 PS2, Line 14: like in https://qa.coreboot.org/job/coreboot-gerrit/121064/console
The URL will get invalid after the build artifects are deleted.
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39922 )
Change subject: soc/intel/common/block: Add missing include ......................................................................
Patch Set 3: Code-Review+1
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39922 )
Change subject: soc/intel/common/block: Add missing include ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39922 )
Change subject: soc/intel/common/block: Add missing include ......................................................................
soc/intel/common/block: Add missing include
Include types.h in src/soc/intel/common/block/include/intelblocks/cse.h to use type bool.
Without this, there can be a build error like below,
src/soc/intel/common/block/include/intelblocks/cse.h:208:1: error: unknown type name 'bool'; did you mean '_Bool'? bool cse_is_hfs1_com_soft_temp_disable(void); ^~~~ _Bool src/soc/intel/common/block/include/intelblocks/cse.h:214:1: error: unknown type name 'bool'; did you mean '_Bool'? bool cse_is_hfs3_fw_sku_custom(void);
Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com Change-Id: I92ee533bca7dc255f7a341b2a68bbc09900996a1 Reviewed-on: https://review.coreboot.org/c/coreboot/+/39922 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/soc/intel/common/block/include/intelblocks/cse.h 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h index 2c81383..ead5d41 100644 --- a/src/soc/intel/common/block/include/intelblocks/cse.h +++ b/src/soc/intel/common/block/include/intelblocks/cse.h @@ -17,6 +17,7 @@ #define SOC_INTEL_COMMON_CSE_H
#include <stdint.h> +#include <types.h>
/* MKHI Command groups */ #define MKHI_GROUP_ID_CBM 0x0
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39922 )
Change subject: soc/intel/common/block: Add missing include ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1939 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1938 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1937
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Rizwan Qureshi (Code Review)
-
Wonkyu Kim (Code Review)