[M] Change in coreboot[main]: ec/starlabs/merlin: Always use ECRD and ECWR when accessing EC memory

[Sean Rhodes (Code Review)]

Attention is currently required from: Sean Rhodes.

Hello Matt DeVillier, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/84734?usp=email

to look at the new patch set (#7).

Change subject: ec/starlabs/merlin: Always use ECRD and ECWR when accessing EC memory
......................................................................

ec/starlabs/merlin: Always use ECRD and ECWR when accessing EC memory

Ensure any reads or writes to the EC memory, are performed with ECRD
(Read) and ECWR (Write) as these methods use a mutex.

Also, use local variables to cache reads of the same variable within
a given ACPI method.

This solves:
    Initialized Arguments for Method [ECRD]:  (1 arguments defined for method invocation)
        Arg0:   00000000967261a4 [RefOf] <Node>          Name ECPS RegionField 000000007d4b8073

ACPI Error: Aborting method _SB.PCI0.LPCB.EC.ECRD due to previous error (AE_BAD_PARAMETER) (20230628/psparse-529)
    ACPI Error: Aborting method _SB.PCI0.LPCB.EC.ADP1._PSR due to previous error (AE_BAD_PARAMETER) (20230628/psparse-529)

Change-Id: I0bbb538017cc004bff1989a8017ccfcd1ba9ab5c
Signed-off-by: Sean Rhodes 
---
M src/ec/starlabs/merlin/acpi/battery.asl
M src/ec/starlabs/merlin/acpi/ec.asl
M src/ec/starlabs/merlin/acpi/suspend.asl
M src/ec/starlabs/merlin/variants/apl/events.asl
M src/ec/starlabs/merlin/variants/cezanne/events.asl
M src/ec/starlabs/merlin/variants/glk/events.asl
M src/ec/starlabs/merlin/variants/glkr/events.asl
M src/ec/starlabs/merlin/variants/kbl/events.asl
M src/ec/starlabs/merlin/variants/merlin/events.asl
9 files changed, 46 insertions(+), 41 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/84734/7