Attention is currently required from: Cliff Huang, Maulik V Vaghela, Subrata Banik, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59855 )
Change subject: soc/intel/common/block/pcie/rtd3: Add ModPHY power gate support for RTD3
......................................................................
Patch Set 3:
(3 comments)
File src/soc/intel/common/block/pcie/rtd3/rtd3.c:
https://review.coreboot.org/c/coreboot/+/59855/comment/ebccc236_2fbd0fa8
PS3, Line 83: bool enabl
Just thoughts: […]
good eyes, I like it!
https://review.coreboot.org/c/coreboot/+/59855/comment/f3d99b85_a86a84d8
PS3, Line 112: pcie_rtd3_enable_modphy_pg(pcie_rp, false);
pcie_rtd3_enable_modphy_pg(pcie_rp, PG_DISABLE);
Done
https://review.coreboot.org/c/coreboot/+/59855/comment/08631dc6_3c778b66
PS3, Line 159: pcie_rtd3_enable_modphy_pg(pcie_rp, true);
pcie_rtd3_enable_modphy_pg(pcie_rp, PG_ENABLE);
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59855
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19cb05a74acfa3ded7867b1cac32c161a83b4f7d
Gerrit-Change-Number: 59855
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 08 Dec 2021 21:39:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment