Attention is currently required from: Alok Agarwal, Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Paul Menzel, Pranava Y N, Vikrant L Jadeja.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85454?usp=email )
Change subject: soc/intel/pantherlake: Display Sign-of-Life during memory training
......................................................................
Patch Set 16:
(2 comments)
File src/soc/intel/pantherlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/85454/comment/28c46d4d_6b97ac93?usp... :
PS16, Line 366:
: #define UX_MEMORY_TRAINING_DESC "memory_training_desc"
not needed
https://review.coreboot.org/c/coreboot/+/85454/comment/9d4ecb26_ff809a12?usp... :
PS16, Line 384: const char *text = ux_locales_get_text(UX_MEMORY_TRAINING_DESC);
: /* No localized text found; fallback to built-in English. */
: if (!text)
: text = "Your device is finishing an update. "
: "This may take 1-2 minutes.\n"
: "Please do not turn off your device.";
just use
```
const char *text = ux_locales_get_text(UX_LOCALE_MSG_MEMORY_TRAINING);
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85454?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I993eb0d59cd01fa62f35a77f84e262e389efb367
Gerrit-Change-Number: 85454
Gerrit-PatchSet: 16
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Alok Agarwal
alok.agarwal@intel.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Vikrant L Jadeja
vikrant.l.jadeja@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Vikrant L Jadeja
vikrant.l.jadeja@intel.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Attention: Alok Agarwal
alok.agarwal@intel.com
Gerrit-Comment-Date: Mon, 17 Feb 2025 07:25:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No