Attention is currently required from: Xi Chen, Martin Roth, Rex-BC Chen, Yidi Lin.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52541 )
Change subject: soc/mediatek/mt8195: Add timer support
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Another thing...
I just realized timer_soc is not the common pattern we'll be using. Really sorry but can you rename the files again to:
common/include/soc/timer.h => common/include/soc/timer_common.h
mt8173/include/soc/timer_soc.h => timer.h
mt8183/include/soc/timer_soc.h => timer.h
mt8192/include/soc/timer_soc.h => timer.h
mt8195/include/soc/timer_soc.h => timer.h
And in timer_v1.h / timer_v2.h, do:
#include <soc/timer_common.h>
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52541
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6a87e7d5983bf14ad123de82ed670a22a7be1aa
Gerrit-Change-Number: 52541
Gerrit-PatchSet: 5
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Comment-Date: Thu, 22 Apr 2021 08:49:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment