Attention is currently required from: Martin Roth.
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51069 )
Change subject: mb/google/guybrush: Add option to toggle GPIO for sign of life
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/guybrush/bootblock.c:
https://review.coreboot.org/c/coreboot/+/51069/comment/67f61d73_6a00eed7
PS3, Line 17: struct soc_amd_gpio sol = PAD_GPO(GPIO_31, LOW);
This uses a lot more code than we need. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51069
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I069623ae76a4e4d1e43a47dd95fdfcece398ebfb
Gerrit-Change-Number: 51069
Gerrit-PatchSet: 5
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Thu, 25 Feb 2021 22:11:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment