Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30385 )
Change subject: soc/intel/broadwell: Enable LPC/SIO setup in bootblock ......................................................................
Patch Set 43:
(4 comments)
https://review.coreboot.org/#/c/30385/43/src/mainboard/google/jecht/bootbloc... File src/mainboard/google/jecht/bootblock.c:
https://review.coreboot.org/#/c/30385/43/src/mainboard/google/jecht/bootbloc... PS43, Line 22: void mainboard_pre_console_init(void) Please use bootblock_mainboard_early_init() (#include <bootblock_common.h>).
https://review.coreboot.org/#/c/30385/43/src/mainboard/google/jecht/bootbloc... PS43, Line 31: spurious linebreak?
https://review.coreboot.org/#/c/30385/43/src/soc/intel/broadwell/Kconfig File src/soc/intel/broadwell/Kconfig:
https://review.coreboot.org/#/c/30385/43/src/soc/intel/broadwell/Kconfig@48 PS43, Line 48: select BOOTBLOCK_CONSOLE Defaults to `y` and has a prompt, please don't select.
https://review.coreboot.org/#/c/30385/43/src/soc/intel/broadwell/romstage/ro... File src/soc/intel/broadwell/romstage/romstage.c:
https://review.coreboot.org/#/c/30385/43/src/soc/intel/broadwell/romstage/ro... PS43, Line 135: Drop declaration in `soc/romstage.h`.
-
Nico Huber (Code Review)