build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29205 )
Change subject: mb/google/fizz/variants/kalista: Add variant for kalista ......................................................................
Patch Set 1:
(8 comments)
https://review.coreboot.org/#/c/29205/1/src/mainboard/google/fizz/variants/k... File src/mainboard/google/fizz/variants/kalista/gpio.c:
https://review.coreboot.org/#/c/29205/1/src/mainboard/google/fizz/variants/k... PS1, Line 124: /* ISH_I2C0_SDA */ PAD_CFG_NF(GPP_D5, NONE, DEEP, NF1), /* PCH_I2C0_8625_SDA */ line over 80 characters
https://review.coreboot.org/#/c/29205/1/src/mainboard/google/fizz/variants/k... PS1, Line 125: /* ISH_I2C0_SCL */ PAD_CFG_NF(GPP_D6, NONE, DEEP, NF1), /* PCH_I2C0_8625_SCL */ line over 80 characters
https://review.coreboot.org/#/c/29205/1/src/mainboard/google/fizz/variants/k... PS1, Line 142: /* DMIC_CLK0 */ PAD_CFG_NF(GPP_D19, NONE, DEEP, NF1), /* PCH_DMIC_CLK0 */ line over 80 characters
https://review.coreboot.org/#/c/29205/1/src/mainboard/google/fizz/variants/k... PS1, Line 143: /* DMIC_DATA0 */ PAD_CFG_NF(GPP_D20, NONE, DEEP, NF1), /* PCH_DMIC_DATA0 */ line over 80 characters
https://review.coreboot.org/#/c/29205/1/src/mainboard/google/fizz/variants/k... PS1, Line 158: /* CPU_GP1 */ PAD_CFG_GPI_APIC(GPP_E7, NONE, PLTRST), /* TOUCHSCREEN_INT# */ line over 80 characters
https://review.coreboot.org/#/c/29205/1/src/mainboard/google/fizz/variants/k... PS1, Line 183: /* I2S2_SCLK */ PAD_CFG_GPI_GPIO_DRIVER(GPP_F0, NONE, DEEP), /* I2S_2_BCLK */ line over 80 characters
https://review.coreboot.org/#/c/29205/1/src/mainboard/google/fizz/variants/k... PS1, Line 184: /* I2S2_SFRM */ PAD_CFG_GPI_GPIO_DRIVER(GPP_F1, NONE, DEEP), /* I2S_2_FS_LRC */ line over 80 characters
https://review.coreboot.org/#/c/29205/1/src/mainboard/google/fizz/variants/k... PS1, Line 185: /* I2S2_TXD */ PAD_CFG_GPI_GPIO_DRIVER(GPP_F2, NONE, DEEP), /* I2S2_2_TX_DAC */ line over 80 characters